-
Notifications
You must be signed in to change notification settings - Fork 28
K8s support for specifying an existing persistent volume claim #661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4d78a97
to
8272053
Compare
This can be tested with the following terraform config (
Once the config is applied, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for letting this pull request “breathe” for too long. 🙈 I believe it'll be more practical to merge it and submit a global review once you open a pull request for the feature branch-
* Support for existing storage containers in aws and gcp. (#651) * Update config schema. * AWS support for existing S3 buckets. * Existing bucket support for gcp. * Add mocks and tests to existing bucket resource in aws. * Update docs with new pre-allocated container fields. * Support using pre-allocated blob containers in azure. (#660) * AWS support for existing S3 buckets. * Existing bucket support for gcp. * Fix subdirectory in rclone remote. * Blob container generates the rclone connection string. * Introduce a type for generating rclone connection strings. * Azure support for reusable blob containers. * Update docs. * Fix path prefix. * Initialize s3 existing bucket with RemoteStorage struct. * Update gcp and aws existing bucket data sources to align with the azure data source. Use common.RemoteStorage to initialize the data sources. Using rclone to verify storage during Read. Remove aws s3 client mocks and tests that rely on them. * Fix comment. * K8s support for specifying an existing persistent volume claim (#661) * K8s support for specifying an existing persistent volume claim. Co-authored-by: Helio Machado <[email protected]> * Update use of Identifier struct. * Combine container and container_path config keys. * Update docs. * Use split function from rclone. Co-authored-by: Helio Machado <[email protected]>
No description provided.