Skip to content

Implement human-readable random identifier generation #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 9, 2022
Merged

Implement human-readable random identifier generation #653

merged 5 commits into from
Sep 9, 2022

Conversation

0x2b3bfa0
Copy link
Member

Now users can run e.g. task create --name experiment to create a task named experiment with a randomly generated suffix, avoiding clashes due to cloud providers' globally unique resource name requirements.

Note
Terraform resources' behavior remains unaltered and fully backwards-compatible. This change only affects the standalone command-line tool.

@0x2b3bfa0 0x2b3bfa0 added enhancement New feature or request ui/ux User interface/experience labels Sep 3, 2022
@0x2b3bfa0 0x2b3bfa0 self-assigned this Sep 3, 2022
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic September 3, 2022 00:25 Inactive
@0x2b3bfa0 0x2b3bfa0 linked an issue Sep 3, 2022 that may be closed by this pull request
Allow users to specify custom identifiers with a random suffix #652
Closed
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic September 3, 2022 00:25 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic September 3, 2022 00:25 Inactive
@0x2b3bfa0 0x2b3bfa0 requested a review from a team September 3, 2022 00:26
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic September 3, 2022 00:56 Inactive
@0x2b3bfa0 0x2b3bfa0 requested a deployment to automatic September 3, 2022 00:57 Abandoned
@0x2b3bfa0 0x2b3bfa0 requested a deployment to automatic September 3, 2022 00:57 Abandoned
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic September 3, 2022 00:57 Inactive
@0x2b3bfa0 0x2b3bfa0 changed the title Allow human-readable identifier generation Implement human-readable random identifier generation Sep 3, 2022
tasdomas
tasdomas suggested changes Sep 3, 2022
View reviewed changes
Copy link
Contributor

@tasdomas tasdomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, but..

exposed declarations need a short docstring identifying them, for an overview of go documentation guidelines see go.dev

0x2b3bfa0
0x2b3bfa0 commented Sep 3, 2022
View reviewed changes
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic September 4, 2022 13:50 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic September 4, 2022 13:51 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic September 4, 2022 13:51 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic September 4, 2022 13:51 Inactive
@0x2b3bfa0 0x2b3bfa0 requested a review from tasdomas September 4, 2022 13:51
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic September 5, 2022 01:58 Inactive
@0x2b3bfa0 0x2b3bfa0 requested a deployment to automatic September 5, 2022 01:58 Abandoned
@0x2b3bfa0 0x2b3bfa0 requested a deployment to automatic September 5, 2022 01:58 Abandoned
@0x2b3bfa0 0x2b3bfa0 requested a deployment to automatic September 5, 2022 01:58 Abandoned
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic September 8, 2022 02:39 Inactive
@tasdomas
Copy link
Contributor

tasdomas commented Sep 9, 2022

Let's pass the tests and land this - contrary to popular belief PRs do not need time to "breathe" :)

@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic September 9, 2022 08:38 Inactive
@0x2b3bfa0 0x2b3bfa0 requested a deployment to automatic September 9, 2022 08:38 Abandoned
@0x2b3bfa0 0x2b3bfa0 requested a deployment to automatic September 9, 2022 08:38 Abandoned
@0x2b3bfa0 0x2b3bfa0 requested a deployment to automatic September 9, 2022 08:38 Abandoned
@0x2b3bfa0
Copy link
Member Author

contrary to popular belief PRs do not need time to "breathe"

Pull requests probably don't, but developers do. 🤣

@0x2b3bfa0
Copy link
Member Author

Let me see if I can pass the tests: this pull request modifies code that is common to every “cloud” and I would like all the smoke tests to pass.

@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic September 9, 2022 08:49 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic September 9, 2022 08:49 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic September 9, 2022 15:18 Inactive
@0x2b3bfa0 0x2b3bfa0 requested a deployment to automatic September 9, 2022 15:18 Abandoned
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic September 9, 2022 15:18 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic September 9, 2022 15:18 Inactive
@0x2b3bfa0
Copy link
Member Author

It looks like Kubernetes succeeded, despite the last failed run; merging...

@0x2b3bfa0 0x2b3bfa0 merged commit 64d3d0d into master Sep 9, 2022
@0x2b3bfa0 0x2b3bfa0 deleted the human-readable branch September 9, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@tasdomas tasdomas tasdomas approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@0x2b3bfa0 0x2b3bfa0

Labels
enhancement New feature or request ui/ux User interface/experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow users to specify custom identifiers with a random suffix
2 participants
@0x2b3bfa0 @tasdomas