Cleanup fixed_cfg.pb.go #356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Douglas Reid <[email protected]>
googlebot
added
the
cla: yes
guptasu
approved these changes
Feb 3, 2018
incfly
pushed a commit
to incfly/api
that referenced
this pull request
Jun 13, 2018
* Added unit tests for ApiManager and RequestHandler * Fixed code formatting * Simplified duplicated variables * Removed unused constant variables * Added more comments
incfly
pushed a commit
to incfly/api
that referenced
this pull request
Jun 13, 2018
Automatic merge from submit-queue. [DO NOT MERGE] Auto PR to update dependencies of mixerclient This PR will be merged automatically once checks are successful. ```release-note none ```
nacx
pushed a commit
to nacx/api
that referenced
this pull request
Feb 23, 2022
…ure (istio#356) * Return AppliedObjectList instead of Emoty at service CLI Apply procedure When an apply aperation is invoqued and no error is returned, the invoquer has not information if the applied object was created, updated, or unchanged. To give more information about the apply's opperation, we will return: - The status of each individual applied object. - The applied object itself. The whole object is needed to being able to construct the object's fqn. A new message called `AppliedObject` is created to encapsulate the status and the applied object. Signed-off-by: Marc Navarro Sonnenfeld <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we removed goimports from the fixed_cfg.pb.go generation,
we lost the ability to clean up the now unused google_protobuf
import. This PR restores that cleaning.