Correct a small makefile issue #355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
geeknoid
requested review from
kyessenov,
liminw and
ZackButcher
as code owners
douglas-reid
suggested changes
Feb 3, 2018
Makefile
Outdated
| @sed -e 's/*google_protobuf.Struct/interface{}/g' -e 's/ValueType_VALUE_TYPE_UNSPECIFIED/VALUE_TYPE_UNSPECIFIED/g' mixer/v1/config/cfg.pb.go >mixer/v1/config/fixed_cfg.pb.go | ||
| @sed -e 's/*google_protobuf.Struct/interface{}/g' \ | ||
| -e 's/ValueType_VALUE_TYPE_UNSPECIFIED/VALUE_TYPE_UNSPECIFIED/g' \ | ||
| -e 's/package config/package istio_mixer_v1_config/g' \ |
There was a problem hiding this comment.
i don't think we want to do this. let's fix the package in istio/istio
|
Can we deal with the naming in a separate PR? I'm trying to get a bunch of doc work done, and the fact this is currently broken makes it so I can't do "go generate" on the protos in istio/istio. With this fix, the end to end pipeline is working. |
|
Let's use this: istio/istio#3146. The package in istio/istio is not needed. And we will simplify the codegen. |
geeknoid
changed the title
|
PTAL |
- Was passing a incorrect directory when building the protoc-gen-doc plugin. Not sure how come this worked before, but the directory was definitely incrrect. - Sync to the latest doc gen tool.
nacx
added a commit
to nacx/api
that referenced
this pull request
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was passing a incorrect directory when building the protoc-gen-doc plugin. Not sure how come this worked before,
but the directory was definitely incrrect.
Sync to the latest doc gen tool.