-
Notifications
You must be signed in to change notification settings - Fork 39
Fix fatal error handling in V3 API #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There is some duplicate code in the error handling logic now, I'll look into ways to improve that as well. |
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #126 +/- ##
==========================================
- Coverage 86.72% 86.43% -0.29%
==========================================
Files 29 29
Lines 2455 2492 +37
==========================================
+ Hits 2129 2154 +25
- Misses 326 338 +12
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm following maybe 50% of what happens here with the states and the code, but overall looks reasonable. Thanks for looking into it!
This is related to #119.
This fixes some of the problems @osaxma has discovered and reported in that issue:
_pending
operation without properly clearing it when we're done.ReadyForQueryMessage
that we'll never receive._sendAndWaitForQuery
can lead to errors being swallowed.This PR should fix all of them, so I've migrated the fixme test into the main v3 test file.