Skip to content

Fix fatal error handling in V3 API #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 1, 2023
Merged

Fix fatal error handling in V3 API #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
db607b3
Fix fatal error handling in V3 API
simolus3 Aug 28, 2023
43aedf7
Use fresh container for each test
simolus3 Aug 29, 2023
7f26c12
Hopefully fix CI timeouts?
simolus3 Aug 31, 2023
4663d29
Reduce chance for race condition in test
simolus3 Aug 31, 2023
ac3bbee
Don't dispose after connection close
simolus3 Aug 31, 2023
361fd97
Fix statements not throwing when closed
simolus3 Aug 31, 2023
c49eff8
Fix pool tests
simolus3 Aug 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/dart.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ on:
jobs:
build:
runs-on: ubuntu-latest
timeout-minutes: 10

steps:
- uses: actions/checkout@v3
Expand Down
1 change: 1 addition & 0 deletions lib/src/message_window.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ Map<int, _ServerMessageFn> _messageTypeMap = {
110: (d) => NoDataMessage(),
116: ParameterDescriptionMessage.new,
$3: (d) => CloseCompleteMessage(),
$N: NoticeMessage.new,
};

class MessageFramer {
Expand Down
12 changes: 10 additions & 2 deletions lib/src/server_messages.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ import 'types.dart';

abstract class ServerMessage extends BaseMessage {}

class ErrorResponseMessage implements ServerMessage {
sealed class ErrorOrNoticeMessage implements ServerMessage {
final fields = <ErrorField>[];

ErrorResponseMessage(Uint8List bytes) {
ErrorOrNoticeMessage(Uint8List bytes) {
final reader = ByteDataReader()..add(bytes);

int? identificationToken;
Expand All @@ -39,6 +39,10 @@ class ErrorResponseMessage implements ServerMessage {
}
}

class ErrorResponseMessage extends ErrorOrNoticeMessage {
ErrorResponseMessage(super.bytes);
}

class AuthenticationMessage implements ServerMessage {
static const int KindOK = 0;
static const int KindKerberosV5 = 2;
Expand Down Expand Up @@ -244,6 +248,10 @@ class NoDataMessage extends ServerMessage {
String toString() => 'No Data Message';
}

class NoticeMessage extends ErrorOrNoticeMessage {
NoticeMessage(super.bytes);
}

/// Identifies the message as a Start Copy Both response.
/// This message is used only for Streaming Replication.
class CopyBothResponseMessage implements ServerMessage {
Expand Down
Loading