chore(deps): Bump ionicons from 7.1.0 to 7.1.2 in /core #27540
Conversation
Bumps [ionicons](https://github.com/ionic-team/ionicons) from 7.1.0 to 7.1.1. - [Release notes](https://github.com/ionic-team/ionicons/releases) - [Changelog](https://github.com/ionic-team/ionicons/blob/main/CHANGELOG.md) - [Commits](ionic-team/ionicons@v7.1.0...v7.1.1) --- updated-dependencies: - dependency-name: ionicons dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
the
dependencies
|
|
|
I'm guessing these screenshots are showing diffs because Playwright is not using Safari 16.4+ as needed for |
liamdebeasi
force-pushed
the
dependabot/npm_and_yarn/core/ionicons-7.1.1
branch
from
2602047 to
7286d97
Compare
|
We should wait for ionic-team/ionicons#1223 to ship before merging this PR |
| return result[1]; | ||
| /** | ||
| * Set the direction before the tests start | ||
| * to avoid https://bugs.webkit.org/show_bug.cgi?id=257133 |
There was a problem hiding this comment.
I need to add a tech debt ticket to remove this once the bug has been fixed/released in Safari and Playwright has been updated.
mapsandapps
left a comment
mapsandapps
left a comment
There was a problem hiding this comment.
LGTM. thanks for figuring this out!
i'm going to "request changes" since we don't want to merge this yet. as mentioned above, the needed changes are:
- fix issues with ionicons, ship 7.1.2, and update this PR to use the new version
- make a tech debt ticket
liamdebeasi
changed the title
|
A newer version of ionicons exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
|
Closing in favor of updating this in the feature-7.3 branch: #27925 |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps ionicons from 7.1.0 to 7.1.1.
Release notes
Sourced from ionicons's releases.
Changelog
Sourced from ionicons's changelog.
Commits
0fd6399v7.1.17466383chore(): update dev dependencies (#1216)31ea945docs(): change link from slack to discord (#1217)e70bf21fix(icon): respond to changes of document dir (#1210)fb46c75chore(ci): update workflows for upcoming deprecations (#1209)4b2ed58chore(readme): ionic slack -> discord (#1208)c86778cchore(ci): enable npm package provenance (#1206)99bb8f6merge release-7.1.03691e75chore: remove duplicate changelog diff3904e85chore(): update package lock filesYou can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)