Skip to content

Conversation

@FayeDel
Copy link
Collaborator

@FayeDel FayeDel commented May 11, 2022

About

This PR lines up all of the commits on unstable and moving to stable to the changes needed to bring to an upcoming release, v4.2.1, which primarily addresses fixes to bugs relating to synchronisation and autocomplete.

Checklist

  • I've ran pre-commit to format and lint the change(s) made.
  • I've checked to make sure the change(s) work on 3.8.6 and higher.
  • This fixes/solves an Issue.
    • (If existent):
  • I've made this pull request for/as: (check all that apply)
    • Documentation
    • Breaking change
    • New feature/enhancement
    • Bugfix

FayeDel and others added 3 commits May 6, 2022 18:35
* fix: Allow sub command autocompletew dispatch

* ci: correct from checks.

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…t `application.commands` scope; allow modifying channels outside of a category (#780)

* refactor: optimize sync behavior

* ooops

* Update interactions/api/http/interaction.py

Co-authored-by: Toricane <[email protected]>

* Update interactions/client/bot.pyi

Co-authored-by: Toricane <[email protected]>

* Update interactions/api/http/scheduledEvent.py

Co-authored-by: Toricane <[email protected]>

* Update interactions/client/bot.py

Co-authored-by: Toricane <[email protected]>

* Update bot.py

* ci: correct from checks.

* fix: Fix command check for user and member decorator

* Update interactions/client/bot.py

Co-authored-by: Toricane <[email protected]>

* fix!: Fix autocomplete when sync is disabled

* Update bot.py

* Update bot.py

* Update bot.pyi

* ci: correct from checks.

* Update bot.py

* fix: fix option checks and autocomplete dispatch with command names

* ci

* refactor: unnecessary if checks

* fix!: Fix synchronisation by properly checking attributes and their logic comparators.

* refactor: Remove print statements.

* refactor: move sync and autocomplete into _ready

* doc: add warning

* Update interactions/client/bot.py

Co-authored-by: Toricane <[email protected]>

* refactor!: Consider extensions in the sync process

* ci: correct from checks.

* i hate merge conflicts

* purge: remove debugging changes

* Update interactions/client/bot.py

Co-authored-by: Toricane <[email protected]>

* Update interactions/client/bot.py

Co-authored-by: Toricane <[email protected]>

* fix: consider loading after bot start

* ci: correct from checks.

* refactor: make compare sync static

* ci: correct from checks.

* fix: consider sync toggle on load

* fix: Fix attribute reference typo.

* fix!: Attempt to fix critical error on startup with JSONException

* add check

* fix

* refactor: change raise to warning if sync is off

* ci: correct from checks.

* fix!: continue

* fix!: fix snyc bug if the bot does not have the `application.commands` scope; include checks for subcommands

* fix: fix permission overwrite serialization and allow modifying channels without category

* ci

Co-authored-by: Toricane <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: DeltaX <[email protected]>
@FayeDel FayeDel added enhancement New feature or request breaking This contains breaking changes priority This Issue/PR must be resolved first before accepting any others labels May 11, 2022
@FayeDel FayeDel self-assigned this May 11, 2022
Copy link
Contributor

@Toricane Toricane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@quinchs quinchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this queen!

@FayeDel FayeDel added the documentation Improvements or additions to documentation label May 13, 2022
@FayeDel FayeDel merged commit 142be46 into stable May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking This contains breaking changes documentation Improvements or additions to documentation enhancement New feature or request priority This Issue/PR must be resolved first before accepting any others

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants