-
Notifications
You must be signed in to change notification settings - Fork 185
chore!: release 4.2.1 #785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: Allow sub command autocompletew dispatch * ci: correct from checks. Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…t `application.commands` scope; allow modifying channels outside of a category (#780) * refactor: optimize sync behavior * ooops * Update interactions/api/http/interaction.py Co-authored-by: Toricane <[email protected]> * Update interactions/client/bot.pyi Co-authored-by: Toricane <[email protected]> * Update interactions/api/http/scheduledEvent.py Co-authored-by: Toricane <[email protected]> * Update interactions/client/bot.py Co-authored-by: Toricane <[email protected]> * Update bot.py * ci: correct from checks. * fix: Fix command check for user and member decorator * Update interactions/client/bot.py Co-authored-by: Toricane <[email protected]> * fix!: Fix autocomplete when sync is disabled * Update bot.py * Update bot.py * Update bot.pyi * ci: correct from checks. * Update bot.py * fix: fix option checks and autocomplete dispatch with command names * ci * refactor: unnecessary if checks * fix!: Fix synchronisation by properly checking attributes and their logic comparators. * refactor: Remove print statements. * refactor: move sync and autocomplete into _ready * doc: add warning * Update interactions/client/bot.py Co-authored-by: Toricane <[email protected]> * refactor!: Consider extensions in the sync process * ci: correct from checks. * i hate merge conflicts * purge: remove debugging changes * Update interactions/client/bot.py Co-authored-by: Toricane <[email protected]> * Update interactions/client/bot.py Co-authored-by: Toricane <[email protected]> * fix: consider loading after bot start * ci: correct from checks. * refactor: make compare sync static * ci: correct from checks. * fix: consider sync toggle on load * fix: Fix attribute reference typo. * fix!: Attempt to fix critical error on startup with JSONException * add check * fix * refactor: change raise to warning if sync is off * ci: correct from checks. * fix!: continue * fix!: fix snyc bug if the bot does not have the `application.commands` scope; include checks for subcommands * fix: fix permission overwrite serialization and allow modifying channels without category * ci Co-authored-by: Toricane <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: DeltaX <[email protected]>
EepyElvyra
approved these changes
May 11, 2022
Toricane
approved these changes
May 12, 2022
Contributor
Toricane
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
quinchs
approved these changes
May 13, 2022
quinchs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this queen!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking
This contains breaking changes
documentation
Improvements or additions to documentation
enhancement
New feature or request
priority
This Issue/PR must be resolved first before accepting any others
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This PR lines up all of the commits on
unstableand moving tostableto the changes needed to bring to an upcoming release,v4.2.1, which primarily addresses fixes to bugs relating to synchronisation and autocomplete.Checklist
pre-committo format and lint the change(s) made.3.8.6and higher.