Skip to content

fix(channel, sync): Prevent bot from crashing if it is invited without application.commands scope; allow modifying channels outside of a category #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
EepyElvyra merged 63 commits into from
May 11, 2022
Merged

fix(channel, sync): Prevent bot from crashing if it is invited without application.commands scope; allow modifying channels outside of a category #780

EepyElvyra merged 63 commits into from
May 11, 2022

Conversation

@EepyElvyra
Copy link
Contributor

@EepyElvyra EepyElvyra commented May 8, 2022

About

Checklist

EepyElvyra and others added 30 commits April 26, 2022 21:07
@EepyElvyra
refactor: optimize sync behavior
2ede85f
@EepyElvyra
ooops
14fb6d7
@EepyElvyra @Toricane
Update interactions/api/http/interaction.py
0256ebd 
Co-authored-by: Toricane <[email protected]>
@EepyElvyra @Toricane
Update interactions/client/bot.pyi
c447bea 
Co-authored-by: Toricane <[email protected]>
@EepyElvyra @Toricane
Update interactions/api/http/scheduledEvent.py
dba98de 
Co-authored-by: Toricane <[email protected]>
@EepyElvyra @Toricane
Update interactions/client/bot.py
7e72baa 
Co-authored-by: Toricane <[email protected]>
@EepyElvyra
Update bot.py
11acf4b
@pre-commit-ci
ci: correct from checks.
7426776
@EepyElvyra
fix: Fix command check for user and member decorator
a749a83
@EepyElvyra
Merge remote-tracking branch 'origin/rework_cmd_sync' into rework_cmd…
a328711 
…_sync
@EepyElvyra @Toricane
Update interactions/client/bot.py
998c0b3 
Co-authored-by: Toricane <[email protected]>
@EepyElvyra
fix!: Fix autocomplete when sync is disabled
518aad7
@EepyElvyra
Merge remote-tracking branch 'origin/rework_cmd_sync' into rework_cmd…
622f3e2 
…_sync
@EepyElvyra
Update bot.py
951208d
@EepyElvyra
Update bot.py
3bd3820
@EepyElvyra
Update bot.pyi
8e8d59d
@pre-commit-ci
ci: correct from checks.
71e1aad
@EepyElvyra
Update bot.py
2548d63
@EepyElvyra
fix: fix option checks and autocomplete dispatch with command names
a7dcf86
@EepyElvyra
ci
f79c93a
@EepyElvyra
refactor: unnecessary if checks
f08a3d9
@FayeDel
fix!: Fix synchronisation by properly checking attributes and their l…
39cbf95 
…ogic comparators.
@FayeDel
refactor: Remove print statements.
8f7b21a
@EepyElvyra
refactor: move sync and autocomplete into _ready
04ed0a7
@EepyElvyra
doc: add warning
c91d8da
@EepyElvyra @Toricane
Update interactions/client/bot.py
baaeb0d 
Co-authored-by: Toricane <[email protected]>
@EepyElvyra
Merge branch 'unstable' into rework_cmd_sync
95e5f6b
@EepyElvyra
refactor!: Consider extensions in the sync process
c8076da
@EepyElvyra
Merge branch 'unstable' into rework_cmd_sync
75e6db9
@pre-commit-ci
ci: correct from checks.
3b57ee8
@EepyElvyra EepyElvyra requested a review from Toricane May 8, 2022 10:12
AstreaTSS
AstreaTSS reviewed May 8, 2022
View reviewed changes
@AstreaTSS AstreaTSS added the priority This Issue/PR must be resolved first before accepting any others label May 9, 2022
@EepyElvyra EepyElvyra changed the title fix: fix str object has no attribute get by raising JSONException instead fix(channel, sync): Prevent bot from crashing if it is invited without application.commands scope; allow modifying channels outside of a category May 9, 2022
@EepyElvyra EepyElvyra enabled auto-merge (squash) May 9, 2022 19:53
Toricane
Toricane suggested changes May 11, 2022
View reviewed changes
Copy link
Contributor

@Toricane Toricane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small things

Toricane
Toricane approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@Toricane Toricane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EepyElvyra EepyElvyra merged commit efbd720 into interactions-py:unstable May 11, 2022
@EepyElvyra EepyElvyra deleted the rework_cmd_sync branch May 11, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AstreaTSS AstreaTSS AstreaTSS left review comments

@V3ntus V3ntus Awaiting requested review from V3ntus

@FayeDel FayeDel Awaiting requested review from FayeDel

+1 more reviewer

@Toricane Toricane Toricane approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working priority This Issue/PR must be resolved first before accepting any others

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@EepyElvyra @AstreaTSS @V3ntus @FayeDel @Toricane