[SYCL][FPGA] Fix address space in generation of global Intel FPGA ann… #578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otation Invalid bitcast with different address spaces was emmitted as a first argument of Annotations element. This problem caused assertion fail. Signed-off-by: Viktoria Maksimova <[email protected]>
…ic vars Invalid bitcast with different address spaces was emmitted as a first field of ConstantStruct. This problem caused assertion fail. Signed-off-by: Viktoria Maksimova <[email protected]>
asavonic
suggested changes
Sep 2, 2019
Contributor
asavonic
left a comment
asavonic
left a comment
There was a problem hiding this comment.
LGTM. Few minor comments.
asavonic
reviewed
Sep 3, 2019
Signed-off-by: Viktoria Maksimova <[email protected]>
vmaksimo
force-pushed
the
fix_addr_space
branch
from
50ddc47 to
14b6e9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…otation
Invalid bitcast with different address spaces was emmitted as a first argument
of Annotations element. This problem caused assertion fail.
Signed-off-by: Viktoria Maksimova [email protected]