[SYCL][FPGA] Fix address space in generation of global Intel FPGA annotation (#578)

* [SYCL][FPGA] Fix address space in generation of global Intel FPGA annotation

  Invalid bitcast with different address spaces was emmitted as a first argument
  of Annotations element. This problem caused assertion fail.

* [SYCL] Fix address space in generation of annotate attribute for static vars

  Invalid bitcast with different address spaces was emmitted as a first field of
  ConstantStruct. This problem caused assertion fail.

Signed-off-by: Viktoria Maksimova <[email protected]>

Author: vmaksimo

clang/lib/CodeGen/CodeGenModule.cpp

@@ -2231,13 +2231,15 @@ llvm::Constant *CodeGenModule::EmitAnnotateAttr(llvm::GlobalValue *GV,
                  *UnitGV = EmitAnnotationUnit(L),
                  *LineNoCst = EmitAnnotationLineNo(L);
 
+  llvm::Type *ResType = llvm::PointerType::getInt8PtrTy(
+      this->getLLVMContext(), GV->getType()->getPointerAddressSpace());
+
   // Create the ConstantStruct for the global annotation.
   llvm::Constant *Fields[4] = {
-    llvm::ConstantExpr::getBitCast(GV, Int8PtrTy),
-    llvm::ConstantExpr::getBitCast(AnnoGV, Int8PtrTy),
-    llvm::ConstantExpr::getBitCast(UnitGV, Int8PtrTy),
-    LineNoCst
-  };
+      llvm::ConstantExpr::getPointerBitCastOrAddrSpaceCast(GV, ResType),
+      llvm::ConstantExpr::getBitCast(AnnoGV, Int8PtrTy),
+      llvm::ConstantExpr::getBitCast(UnitGV, Int8PtrTy),
+      LineNoCst};
   return llvm::ConstantStruct::getAnon(Fields);
 }
 
@@ -3867,8 +3869,11 @@ void CodeGenModule::addGlobalIntelFPGAAnnotation(const VarDecl *VD,
                    *UnitGV = EmitAnnotationUnit(VD->getLocation()),
                    *LineNoCst = EmitAnnotationLineNo(VD->getLocation());
 
+    llvm::Type *ResType = llvm::PointerType::getInt8PtrTy(
+        this->getLLVMContext(), GV->getType()->getPointerAddressSpace());
     llvm::Constant *C =
-        llvm::ConstantExpr::getPointerBitCastOrAddrSpaceCast(GV, Int8PtrTy);
+        llvm::ConstantExpr::getPointerBitCastOrAddrSpaceCast(GV, ResType);
+
     // Create the ConstantStruct for the global annotation.
     llvm::Constant *Fields[4] = {
         C, llvm::ConstantExpr::getBitCast(AnnoGV, Int8PtrTy),

clang/test/CodeGenSYCL/intel-fpga-local.cpp

@@ -15,9 +15,13 @@
 //CHECK: [[ANN7:@.str[\.]*[0-9]*]] = {{.*}}{memory:MLAB}
 //CHECK: [[ANN8:@.str[\.]*[0-9]*]] = {{.*}}{memory:DEFAULT}{bankwidth:8}
 //CHECK: [[ANN9:@.str[\.]*[0-9]*]] = {{.*}}{memory:DEFAULT}{max_private_copies:4}
+//CHECK: [[ANN16:@.str.[0-9]*]] = {{.*}}foobar
 
 //CHECK: @llvm.global.annotations
-//CHECK-SAME: a_one{{.*}}[[ANN1]]{{.*}}i32 148
+//CHECK-SAME: { i8 addrspace(1)* bitcast (i32 addrspace(1)* @_ZZ3quxiE5a_one to i8 addrspace(1)*)
+//CHECK-SAME: [[ANN1]]{{.*}}i32 152
+//CHECK-SAME: { i8 addrspace(1)* bitcast (i32 addrspace(1)* @_ZZ3quxiE5b_two to i8 addrspace(1)*)
+//CHECK-SAME: [[ANN16]]{{.*}}i32 156
 
 void foo() {
   //CHECK: %[[VAR_ONE:[0-9]+]] = bitcast{{.*}}var_one
@@ -145,10 +149,14 @@ void baz() {
 }
 
 void qux(int a) {
-  static int a_one [[intelfpga::numbanks(2)]];
+  static int a_one [[intelfpga::numbanks(4)]];
   //CHECK: load{{.*}}a_one
   //CHECK: store{{.*}}a_one
   a_one = a_one + a;
+  static int b_two [[clang::annotate("foobar")]];
+  //CHECK: load{{.*}}b_two
+  //CHECK: store{{.*}}b_two
+  b_two = b_two + a;
 }
 
 void field_addrspace_cast() {