[SYCL][HIP] Fix sycl-ls with HIP devices #4698
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue is that `sycl-ls` uses the backend type enum value to index an array of the size of `all`, which when used on a system with HIP devices available would cause out of bounds accesses.
sergey-semenov
requested changes
Oct 5, 2021
Comment on lines
+28
to
+30
| hip = 4, | ||
| all = 5, | ||
| esimd_cpu = 6, |
There was a problem hiding this comment.
Modifying the existing values of this enum will break ABI compatibility. I would suggest fixing the issue in sycl-ls instead, so that it does not rely on the underlying value of all.
There was a problem hiding this comment.
Ooh that makes sense, and I guess all here is actually more to use with the selectors than to indicate the size of the enum, I'll look into updating sycl-ls instead.
|
Closing this, I'll open a different PR with a re-work of |
npmiller
added a commit
to npmiller/llvm
that referenced
this pull request
Oct 5, 2021
This fixes two issues, first `backend::all` is not guaranteed to be the last entry in the backend types enum and shouldn't be used as such. This caused issues for newer backends such as HIP (see intel#4698). The second issue is that the `DeviceNums` vector wasn't being reset between the short output and the verbose output which meant that the device indices printed in the verbose output were incorrect.
|
See: #4704 |
bader
pushed a commit
that referenced
this pull request
Oct 6, 2021
This fixes two issues, first `backend::all` is not guaranteed to be the last entry in the backend types enum and shouldn't be used as such. This caused issues for newer backends such as HIP (see #4698). The second issue is that the `DeviceNums` vector wasn't being reset between the short output and the verbose output which meant that the device indices printed in the verbose output were incorrect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is that
sycl-lsuses the backend type enum value to index anarray of the size of
all, which when used on a system with HIP devicesavailable would cause out of bounds accesses.