Skip to content

[SYCL][HIP] Fix sycl-ls with HIP devices #4698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[SYCL][HIP] Fix sycl-ls with HIP devices #4698

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions sycl/include/CL/sycl/backend_types.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@ enum class backend : char {
level_zero __SYCL2020_DEPRECATED("use 'ext_oneapi_level_zero' instead") =
ext_oneapi_level_zero,
cuda = 3,
all = 4,
esimd_cpu = 5,
hip = 6,
hip = 4,
all = 5,
esimd_cpu = 6,
Comment on lines +28 to +30
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modifying the existing values of this enum will break ABI compatibility. I would suggest fixing the issue in sycl-ls instead, so that it does not rely on the underlying value of all.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh that makes sense, and I guess all here is actually more to use with the selectors than to indicate the size of the enum, I'll look into updating sycl-ls instead.

};

template <backend Backend, typename SYCLObjectT> struct interop;
Expand Down