[SYCL] Fix sycl-ls device indexing #4704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes two issues, first `backend::all` is not guaranteed to be the last entry in the backend types enum and shouldn't be used as such. This caused issues for newer backends such as HIP (see intel#4698). The second issue is that the `DeviceNums` vector wasn't being reset between the short output and the verbose output which meant that the device indices printed in the verbose output were incorrect.
|
@bso-intel, could you please review? |
vladimirlaz
approved these changes
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two issues, first
backend::allis not guaranteed to be thelast entry in the backend types enum and shouldn't be used as such. This
caused issues for newer backends such as HIP (see #4698).
The second issue is that the
DeviceNumsvector wasn't being resetbetween the short output and the verbose output which meant that the
device indices printed in the verbose output were incorrect.