Skip to content

[SYCL][E2E] Use target- requirements in tests that fail to build for all triples #16895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 10, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sycl/test-e2e/Basic/fpga_tests/fpga_pipes.cpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// REQUIRES: accelerator
// REQUIRES: target-spir, accelerator
// https://github.com/intel/llvm/issues/14308
// Temporarily re-enabled for testing purposes.
// If you are facing issues with this test, please leave a comment in:
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/Basic/fpga_tests/fpga_pipes_legacy_ns.cpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// REQUIRES: accelerator
// REQUIRES: target-spir, accelerator
// RUN: %{build} -o %t.out
// RUN: %{run} %t.out
//==-------- fpga_pipes_legacy_ns.cpp - SYCL FPGA pipes test ---------------==//
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
// REQUIRES: accelerator
// REQUIRES: target-spir, accelerator
// RUN: %{build} -o %t.out
// RUN: %{run} %t.out

Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/Basic/multisource_spv_obj.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
//
//===----------------------------------------------------------------------===//

// UNSUPPORTED: cuda || hip
// UNSUPPORTED: target-nvidia || target-amd
//
// Separate kernel sources and host code sources
// RUN: %{build} -fsycl-device-obj=spirv -c -o %t.kernel.o -DINIT_KERNEL -DCALC_KERNEL
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/Basic/stream/blocking_pipes_and_stream.cpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// REQUIRES: accelerator
// REQUIRES: target-spir, accelerator

// RUN: %{build} -o %t.out
// RUN: %{run} %t.out | FileCheck %s
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// Tests whether or not cluster launch was successful, with the correct ranges
// that were passed via enqueue functions extension
// REQUIRES: aspect-ext_oneapi_cuda_cluster_group
// REQUIRES: target-nvidia, aspect-ext_oneapi_cuda_cluster_group
// RUN: %{build} -Xsycl-target-backend --cuda-gpu-arch=sm_90 -o %t.out
// RUN: %{run} %t.out

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// Tests whether or not cluster launch was successful, with the correct ranges
// that were passed via parallel for overload
// REQUIRES: aspect-ext_oneapi_cuda_cluster_group
// REQUIRES: target-nvidia, aspect-ext_oneapi_cuda_cluster_group
// RUN: %{build} -Xsycl-target-backend --cuda-gpu-arch=sm_90 -o %t.out
// RUN: %{run} %t.out

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// Checks whether or not event Dependencies are honored by
// urEnqueueKernelLaunchCustomExp
// REQUIRES: aspect-ext_oneapi_cuda_cluster_group
// REQUIRES: target-nvidia, aspect-ext_oneapi_cuda_cluster_group
// RUN: %{build} -Xsycl-target-backend --cuda-gpu-arch=sm_90 -o %t.out
// RUN: %{run} %t.out

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// Test -fsycl-allow-device-image-dependencies with dynamic libraries.

// UNSUPPORTED: cuda || hip
// UNSUPPORTED: target-nvidia || target-amd
// UNSUPPORTED-INTENDED: Not implemented yet for Nvidia/AMD backends.

// DEFINE: %{dynamic_lib_options} = -fsycl %fPIC %shared_lib -fsycl-allow-device-image-dependencies -I %S/Inputs %if windows %{-DMAKE_DLL %}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@
// RUN: %{run} %t.out

// The name mangling for free function kernels currently does not work with PTX.
// UNSUPPORTED: cuda
// UNSUPPORTED: target-nvidia
// UNSUPPORTED-INTENDED: Not implemented yet for Nvidia/AMD backends.

// XFAIL: hip
// XFAIL: target-amd
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/15742

// XFAIL: spirv-backend && run-mode
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// REQUIRES: aspect-fp64
// UNSUPPORTED: hip || cuda
// UNSUPPORTED: target-amd || target-nvidia
// UNSUPPORTED-INTENDED: Not implemented yet for Nvidia/AMD backends.

// DEFINE: %{mathflags} = %if cl_options %{/clang:-fno-fast-math%} %else %{-fno-fast-math%}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// Test -fsycl-allow-device-image-dependencies with objects.

// UNSUPPORTED: cuda || hip
// UNSUPPORTED: target-nvidia || target-amd
// UNSUPPORTED-INTENDED: Not implemented yet for Nvidia/AMD backends.

// RUN: %clangxx --offload-new-driver -fsycl %S/Inputs/a.cpp -I %S/Inputs -c -o %t_a.o
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Test -fsycl-allow-device-image-dependencies with a single dynamic library on
// Windows and Linux.

// UNSUPPORTED: cuda || hip
// UNSUPPORTED: target-nvidia || target-amd
// UNSUPPORTED-INTENDED: Not implemented yet for Nvidia/AMD backends.

// RUN: %clangxx --offload-new-driver -fsycl %fPIC %shared_lib -fsycl-allow-device-image-dependencies -I %S/Inputs \
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/DeviceImageDependencies/dynamic.cpp
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// Test -fsycl-allow-device-image-dependencies with dynamic libraries.

// UNSUPPORTED: cuda || hip
// UNSUPPORTED: target-nvidia || target-amd

// DEFINE: %{dynamic_lib_options} = -fsycl %fPIC %shared_lib -fsycl-allow-device-image-dependencies -I %S/Inputs %if windows %{-DMAKE_DLL %}
// DEFINE: %{dynamic_lib_suffix} = %if windows %{dll%} %else %{so%}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// REQUIRES: aspect-fp64
// UNSUPPORTED: hip || cuda
// UNSUPPORTED: target-amd || target-nvidia

// DEFINE: %{mathflags} = %if cl_options %{/clang:-fno-fast-math%} %else %{-fno-fast-math%}

Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/DeviceImageDependencies/objects.cpp
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// Test -fsycl-allow-device-image-dependencies with objects.

// UNSUPPORTED: cuda || hip
// UNSUPPORTED: target-nvidia || target-amd

// RUN: %clangxx -fsycl %S/Inputs/a.cpp -I %S/Inputs -c -o %t_a.o
// RUN: %clangxx -fsycl %S/Inputs/b.cpp -I %S/Inputs -c -o %t_b.o
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Test -fsycl-allow-device-image-dependencies with a single dynamic library on Windows
// and Linux.

// UNSUPPORTED: cuda || hip
// UNSUPPORTED: target-nvidia || target-amd

// RUN: %clangxx -fsycl %fPIC %shared_lib -fsycl-allow-device-image-dependencies -I %S/Inputs \
// RUN: %S/Inputs/a.cpp \
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
// REQUIRES: sg-8
// UNSUPPORTED: target-nvidia || target-amd
// UNSUPPORTED-INTENDED: subgroup size requirement implicitly make nvptx/amdgcn
// not supported

// RUN: %{build} -fsycl-device-code-split=per_kernel -o %t.out
// RUN: %{run} %t.out

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
// REQUIRES: sg-8
// UNSUPPORTED: target-nvidia || target-amd
// UNSUPPORTED-INTENDED: subgroup size requirement implicitly make nvptx/amdgcn
// not supported

// RUN: %{build} -fsycl-device-code-split=per_kernel -o %t.out
// RUN: %{run} %t.out

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
// REQUIRES: sg-8
// UNSUPPORTED: target-nvidia || target-amd
// UNSUPPORTED-INTENDED: subgroup size requirement implicitly make nvptx/amdgcn
// not supported

// RUN: %{build} -fsycl-device-code-split=per_kernel -o %t.out
// RUN: %{run} %t.out

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
// REQUIRES: sg-8
// UNSUPPORTED: target-nvidia || target-amd
// UNSUPPORTED-INTENDED: subgroup size requirement implicitly make nvptx/amdgcn
// not supported

// RUN: %{build} -fsycl-device-code-split=per_kernel -o %t.out
// RUN: %{run} %t.out

Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/KernelAndProgram/build-log.cpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// for CUDA and HIP the failure happens at compile time, not during runtime
// UNSUPPORTED: cuda || hip
// UNSUPPORTED: target-nvidia || target-amd
// TODO: rewrite this into a unit-test

// RUN: %{build} -DGPU -o %t_gpu.out
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/KernelAndProgram/cache-build-result.cpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// for CUDA and HIP the failure happens at compile time, not during runtime
// UNSUPPORTED: cuda || hip || ze_debug
// UNSUPPORTED: target-nvidia || target-amd || ze_debug

// RUN: %{build} -DSYCL_DISABLE_FALLBACK_ASSERT=1 -o %t.out
// RUN: %{build} -DSYCL_DISABLE_FALLBACK_ASSERT=1 -DGPU -o %t_gpu.out
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/KernelAndProgram/level-zero-link-flags.cpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// REQUIRES: level_zero
// REQUIRES: target-spir, level_zero
// RUN: %{build} -Xsycl-target-linker=spir64 -foo -o %t.out
// RUN: %{run} %t.out
//==--- level-zero-link-flags.cpp - Error handling for link flags --==//
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/KernelAndProgram/undefined-symbol.cpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// for CUDA and HIP the failure happens at compile time, not during runtime
// UNSUPPORTED: cuda || hip
// UNSUPPORTED: target-nvidia || target-amd

// RUN: %{build} -o %t.out
// RUN: %{run} %t.out
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/LLVMIntrinsicLowering/bitreverse.cpp
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// Test that llvm.bitreverse is lowered correctly by llvm-spirv.

// UNSUPPORTED: hip || cuda
// UNSUPPORTED: target-amd || target-nvidia

// XFAIL: spirv-backend
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16318, CMPLRLLVM-62187
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Test that llvm.bitreverse is lowered correctly by llvm-spirv for 2/4-bit
// types.

// UNSUPPORTED: hip || cuda
// UNSUPPORTED: target-amd || target-nvidia

// XFAIL: gpu
// XFAIL-TRACKER: https://github.com/intel/intel-graphics-compiler/issues/330
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/Regression/acos.cpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// REQUIRES: aspect-fp64
// UNSUPPORTED: cuda || hip
// UNSUPPORTED: target-nvidia || target-amd

// RUN: %{build} -o %t.out
// RUN: %{run} %t.out
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/SPVDumpUse/basic.cpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// REQUIRES: opencl || level_zero
// REQUIRES: target-spir
//
// SYCL_USE_KERNEL_SPV assumes no dead arguments elimination, need to produce
// SPV under the same conditions.
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/SPVDumpUse/kernel_bundle.cpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// REQUIRES: opencl || level_zero
// REQUIRES: target-spir
//
// SYCL_USE_KERNEL_SPV assumes no dead arguments elimination, need to produce
// SPV under the same conditions.
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/SubGroup/attributes.cpp
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// TODO: Despite using a supported required subgroup size compile_sub_group_size
// reports as 0 on cuda and hip
// XFAIL: cuda || hip
// XFAIL: target-nvidia || target-amd
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/14357

// RUN: %{build} -fsycl-device-code-split=per_kernel -o %t.out
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/VirtualFunctions/lit.local.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ import os
# paths like "../../../helper.hpp" in them, so let's just register a
# substitution to add directory with helper headers into include search path
config.substitutions.append(("%helper-includes", "-I {}".format(os.path.dirname(os.path.abspath(__file__)))))
config.required_features += ['aspect-ext_oneapi_virtual_functions']
config.required_features += ['aspect-ext_oneapi_virtual_functions', 'target-spir']
Loading