Skip to content

[SYCL][E2E] Use target- requirements in tests that fail to build for all triples #16895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 10, 2025

Conversation

ayylol
Copy link
Contributor

@ayylol ayylol commented Feb 5, 2025

These tests fail building for all triples, so this pr adds target- requirements to avoid compiling for those triples while in build-only. Previously when in full testing mode these tests were either marked as unsupported for the backend corresponding to a given triple, or required a feature that implicitly made some triples unsupported (i.e., accelerator, or sg-8).

@ayylol ayylol requested review from a team as code owners February 5, 2025 20:51
@ayylol ayylol requested a review from sergey-semenov February 5, 2025 20:51
@ayylol ayylol requested review from aelovikov-intel and removed request for sergey-semenov February 6, 2025 13:41
@ayylol
Copy link
Contributor Author

ayylol commented Feb 7, 2025

@intel/dpcpp-spirv-reviewers Friendly ping

@AlexeySachkov
Copy link
Contributor

These tests fail building for all triples, so this pr adds target- requirements to avoid compiling for those triples while in build-only.

Strictly speaking, that indicates issues in implementation and/or language design of corresponding features. They should either work everywhere, or be guarded by corresponding aspects and therefore be handled by optional kernel features mechanism.

There is no a generic solution for that and I'm not going to object, but list of updated files is a very good list of features which require a more detailed look at them - they all highlight places where "single source runs everywhere" doesn't work at the level "we can't compile it".

@ayylol
Copy link
Contributor Author

ayylol commented Feb 7, 2025

Added two more tests to this pr (ClusterLaunch/enqueueLaunchCustom_check_event_deps.cpp and SubGroup/attributes.cpp). Confirmed that they needed the extra markup here https://github.com/intel/llvm/actions/runs/13203760519/job/36861895735

@ayylol
Copy link
Contributor Author

ayylol commented Feb 10, 2025

@intel/llvm-gatekeepers this is ready to merge. AMD test failure is #16933. Opened new issue for NVIDIA test failure #16951 (Again, this PR is individual test changes and that test is not touched)

@aelovikov-intel aelovikov-intel merged commit b8a2ab7 into intel:sycl Feb 10, 2025
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants