-
Notifications
You must be signed in to change notification settings - Fork 797
[SYCL][E2E] Use target-
requirements in tests that fail to build for all triples
#16895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@intel/dpcpp-spirv-reviewers Friendly ping |
Strictly speaking, that indicates issues in implementation and/or language design of corresponding features. They should either work everywhere, or be guarded by corresponding aspects and therefore be handled by optional kernel features mechanism. There is no a generic solution for that and I'm not going to object, but list of updated files is a very good list of features which require a more detailed look at them - they all highlight places where "single source runs everywhere" doesn't work at the level "we can't compile it". |
Added two more tests to this pr ( |
These tests fail building for all triples, so this pr adds
target-
requirements to avoid compiling for those triples while inbuild-only
. Previously when infull
testing mode these tests were either marked as unsupported for the backend corresponding to a given triple, or required a feature that implicitly made some triples unsupported (i.e.,accelerator
, orsg-8
).