Skip to content

[SYCL] Fix Coverity issues after #16228 #16313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 10, 2024
Merged

[SYCL] Fix Coverity issues after #16228 #16313

merged 2 commits into from
Dec 10, 2024

Conversation

uditagarwal97
Copy link
Contributor

All of these Coverity issues are related to using std::move() instead of variable copy.

@uditagarwal97 uditagarwal97 self-assigned this Dec 10, 2024
@uditagarwal97 uditagarwal97 requested a review from a team as a code owner December 10, 2024 05:05
maarquitos14
maarquitos14 approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@maarquitos14 maarquitos14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For cases using push_back(std::move(...)) you can also go for emplace_back(...), so you don't need explicitly std::move. It's just a matter of style though, so up to you.

@uditagarwal97
Copy link
Contributor Author

@intel/llvm-gatekeepers the PR is ready to be merged.

@sarnex sarnex merged commit a1355e8 into intel:sycl Dec 10, 2024
14 checks passed
KornevNikita pushed a commit that referenced this pull request Feb 25, 2025
@uditagarwal97 @KornevNikita
[SYCL] Fix Coverity issues after #16228 (#16313)
0a30577 
All of these Coverity issues are related to using `std::move()` instead
of variable copy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maarquitos14 maarquitos14 maarquitos14 approved these changes

Assignees

@uditagarwal97 uditagarwal97

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uditagarwal97 @maarquitos14 @sarnex