Skip to content

[SYCL] Support image dependencies in kernel bundles #16228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Dec 4, 2024
Merged

[SYCL] Support image dependencies in kernel bundles #16228

merged 11 commits into from
Dec 4, 2024

Conversation

sergey-semenov
Copy link
Contributor

Add kernel bundle support for image dependencies, which are used for dynamic linking and device virtual function features.

@sergey-semenov sergey-semenov requested a review from a team as a code owner December 2, 2024 12:58
cperkinsintel
cperkinsintel reviewed Dec 2, 2024
View reviewed changes
uditagarwal97
uditagarwal97 approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@uditagarwal97 uditagarwal97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. Just some minor NITs.

@sergey-semenov
Copy link
Contributor Author

There appears to be a flaky failure of the E2E tests, converting to draft to avoid accidental merge

@sergey-semenov sergey-semenov marked this pull request as draft December 3, 2024 20:48
@sergey-semenov sergey-semenov marked this pull request as ready for review December 3, 2024 21:47
@sergey-semenov
Copy link
Contributor Author

Fixed

@uditagarwal97
Copy link
Contributor

@intel/llvm-gatekeepers the PR is ready to be merged.

@steffenlarsen steffenlarsen merged commit e9cbb87 into intel:sycl Dec 4, 2024
14 checks passed
sarnex pushed a commit that referenced this pull request Dec 10, 2024
@uditagarwal97
[SYCL] Fix Coverity issues after #16228 (#16313)
a1355e8 
All of these Coverity issues are related to using `std::move()` instead
of variable copy.
KornevNikita pushed a commit that referenced this pull request Feb 25, 2025
@sergey-semenov @KornevNikita
[SYCL] Support image dependencies in kernel bundles (#16228)
cd419b8 
Add kernel bundle support for image dependencies, which are used for
dynamic linking and device virtual function features.
KornevNikita pushed a commit that referenced this pull request Feb 25, 2025
@uditagarwal97 @KornevNikita
[SYCL] Fix Coverity issues after #16228 (#16313)
0a30577 
All of these Coverity issues are related to using `std::move()` instead
of variable copy.
@sergey-semenov sergey-semenov mentioned this pull request Feb 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cperkinsintel cperkinsintel cperkinsintel left review comments

@uditagarwal97 uditagarwal97 uditagarwal97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sergey-semenov @uditagarwal97 @cperkinsintel @steffenlarsen