Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL] Rename ROCm plugin to HIP #426

Merged
merged 2 commits into from
Sep 14, 2021
Merged

Conversation

npmiller
Copy link

@npmiller npmiller commented Aug 30, 2021

This patch matches the changes in:

It also currently includes the changes from:

This is to avoid conflicts and so that the testing can be run on AMD.

I suggest we try to merge #425 first and then I can rebase this PR (or we could close #425 and merge it with this one).

bader
bader previously approved these changes Aug 30, 2021
vladimirlaz
vladimirlaz previously approved these changes Aug 30, 2021
Fznamznon
Fznamznon previously approved these changes Aug 31, 2021
@npmiller
Copy link
Author

Rebased now that #425 was merged.

vladimirlaz
vladimirlaz previously approved these changes Aug 31, 2021
AlexeySachkov
AlexeySachkov previously approved these changes Sep 2, 2021
AGindinson
AGindinson previously approved these changes Sep 2, 2021
@npmiller
Copy link
Author

npmiller commented Sep 2, 2021

Rebased and updated to also change the on-device tests that were recently moved from the main repo

AGindinson
AGindinson previously approved these changes Sep 2, 2021
kbobrovs
kbobrovs previously approved these changes Sep 2, 2021
Copy link

@kbobrovs kbobrovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESIMD tests LGTM

@bader
Copy link

bader commented Sep 13, 2021

@npmiller, please, resolve merge conflicts.

@npmiller
Copy link
Author

@npmiller, please, resolve merge conflicts.

Rebased and conflicts resolved

@bader bader added the hip Issues related to execution on HIP backend. label Sep 13, 2021
@vladimirlaz vladimirlaz merged commit 5bb592d into intel:intel Sep 14, 2021
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Apr 12, 2022
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hip Issues related to execution on HIP backend.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants