Skip to content

test: maintenance - update midnight url [LW-13684] #2013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 7, 2025
Merged

test: maintenance - update midnight url [LW-13684] #2013

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5c2c4ca
test: maintenance - update midnight url [LW-13684]
tr-io-global Oct 6, 2025
2dc0b9e
Merge branch 'main' into test/maintenance-LW-13684-update-midnight-url
tr-io-global Oct 6, 2025
d823024
Merge branch 'main' into test/maintenance-LW-13684-update-midnight-url
tr-io-global Oct 7, 2025
e64e46a
test: fix assertion
tr-io-global Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/e2e-tests/src/assert/midnightBannerAssert.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ class MidnightBannerAssert {

async assertSeeMidnightURL() {
const EXPECTED_MIDNIGHT_URL = 'https://www.midnight.gd';
await browser.url(EXPECTED_MIDNIGHT_URL);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it is the best solution to fix this failing assertion

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm open to suggestions! We can chat about this in our sync later today.

const currentUrl = await browser.getUrl();
expect(currentUrl).to.contain(EXPECTED_MIDNIGHT_URL);
}
Expand Down
Loading