test: maintenance - update midnight url [LW-13684] #2013
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allure Report
processReports: ✅ test report for e64e46a3
|
wklos-iohk
requested changes
Oct 7, 2025
|
|
||
| async assertSeeMidnightURL() { | ||
| const EXPECTED_MIDNIGHT_URL = 'https://www.midnight.gd'; | ||
| await browser.url(EXPECTED_MIDNIGHT_URL); |
There was a problem hiding this comment.
I don't think it is the best solution to fix this failing assertion
There was a problem hiding this comment.
I'm open to suggestions! We can chat about this in our sync later today.
wklos-iohk
approved these changes
Oct 7, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Proposed solution
A previously passing test started failing with the error AssertionError: expected 'https://midnighttge.io/' to include 'https://www.midnight.gd' as it appears the Midnight app redirects from https://midnighttge.io/ to https://www.midnight.gd. This PR solves the problem by waiting for the redirect to complete before asserting the final URL.
Testing
Run the test and verify that it passes with no new regressions.
ENV=preprod TEST_DAPP_URL=https://ljagiela.github.io/cardano-wallet-connector/ WALLET_1_PASSWORD=*** npx wdio run wdio.conf.chrome.ts --spec ./src/features/MidnightBanner.feature --cucumberOpts.tags='@LW-13628'Screenshots
https://github.com/input-output-hk/lace/actions/runs/18295692889/job/52093921874#step:7:93
