Skip to content

Make reclone with implicit branch update branch in .gitrepo correctly #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jrosdahl
Copy link
Contributor

If the subrepo is tracking a branch and you reclone using

git subrepo clone --force $URL

without specifying -b/--branch then the branch setting in .gitrepo is
not updated.

The command in `.travis.yml` that is supposed to checkout the branch did not actually check out the branch.
Copy link
Collaborator

@grimmySwe grimmySwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Fixes Travis CI build. It was not checking out a branch.
@jrosdahl jrosdahl force-pushed the reclone-with-implicit-branch branch from 1303c97 to 08a3473 Compare December 4, 2019 17:21
If the subrepo is tracking a branch and you reclone using

    git subrepo clone --force $URL

without specifying -b/--branch then the branch setting in .gitrepo is
not updated.
@admorgan
Copy link
Collaborator

admorgan commented Dec 6, 2019

@ingydotnet I would like your opinion on this one. While I agree it makes sense to follow the new branch, I am not sure we should force it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants