Skip to content

Fixes Travis CI build. It was not checking out a branch. #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2019

Conversation

mupdt
Copy link
Contributor

@mupdt mupdt commented May 21, 2018

The command in .travis.yml that is supposed to checkout the branch did not actually check out the branch.

@mupdt mupdt force-pushed the travis-checkout-branch-pls branch 2 times, most recently from 258f6bf to 3a3b199 Compare May 21, 2018 16:18
The command in `.travis.yml` that is supposed to checkout the branch did not actually check out the branch.
@mupdt mupdt force-pushed the travis-checkout-branch-pls branch from 3a3b199 to b7fad46 Compare May 21, 2018 16:36
@mupdt mupdt changed the title Travis CI not checking out a branch. Fixes Travis CI build. It was not checking out a branch. May 22, 2018
@@ -4,18 +4,8 @@ sudo: false
# Want 'bash' but 'c' works:
language: c

branches:
only:
- master
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's nice if we can build branches other than master and release. This makes it easy for forkers to test their non-master branches in their own repositories.

@ingydotnet: Is there are reason only some branches are allowed?

@mupdt mupdt closed this May 24, 2018
@mupdt mupdt deleted the travis-checkout-branch-pls branch May 24, 2018 14:12
@mupdt mupdt restored the travis-checkout-branch-pls branch May 25, 2018 08:28
@mupdt
Copy link
Contributor Author

mupdt commented May 25, 2018

I accidentally deleted my branch. Reopening.

@mupdt mupdt reopened this May 25, 2018
@mupdt
Copy link
Contributor Author

mupdt commented May 25, 2018

@grimmySwe: Hey grimmy, could you check out this PR. It merges into the release/0.4.0 branch. It looks like you're maintaining that branch.

@grimmySwe
Copy link
Collaborator

@mupdt Hi, for me it looks ok, although I don't know if @ingydotnet had any special thoughts with the restrictions?

@mupdt
Copy link
Contributor Author

mupdt commented Jun 14, 2018

@ingydotnet: ping

@ingydotnet
Copy link
Owner

Can you target this PR against master? The release/0.4.0 branch has now been merged.

@mupdt mupdt changed the base branch from release/0.4.0 to master November 13, 2018 20:58
@mupdt
Copy link
Contributor Author

mupdt commented Nov 13, 2018

Can you target this PR against master? The release/0.4.0 branch has now been merged.

Done 👍

@admorgan admorgan merged commit 0e44a65 into ingydotnet:master Dec 4, 2019
@admorgan
Copy link
Collaborator

admorgan commented Dec 4, 2019

Sorry about the false hope, did the wrong thing and it is getting fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants