Skip to content

Include some check that pThermalMax of storages is same or bigger as pThermal from the heat source #1564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Oct 13, 2025
Merged

Include some check that pThermalMax of storages is same or bigger as pThermal from the heat source #1564

merged 12 commits into from
Oct 13, 2025

Conversation

@danielfeismann
Copy link
Member

@danielfeismann
Merge remote-tracking branch 'refs/remotes/origin/df/#1556-thermalSto…
5b5f010 
…rageTypes' into df/tmp_pThermalMaxStorage

# Conflicts:
#	CHANGELOG.md
@danielfeismann
Include some check that pThermalMax of storages is same or bigger as …
a17d410 
…pThermal from the heat source
@danielfeismann danielfeismann added this to the Version 4.1 milestone Oct 6, 2025
@danielfeismann danielfeismann self-assigned this Oct 6, 2025
@danielfeismann danielfeismann added the bug Something isn't working label Oct 6, 2025
@danielfeismann danielfeismann mentioned this pull request Oct 8, 2025
Open
@danielfeismann danielfeismann marked this pull request as ready for review October 9, 2025 07:27
staudtMarius
staudtMarius requested changes Oct 13, 2025
View reviewed changes
Copy link
Member

@staudtMarius staudtMarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one small improvement.

staudtMarius
staudtMarius approved these changes Oct 13, 2025
View reviewed changes
Copy link
Member

@staudtMarius staudtMarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@staudtMarius staudtMarius merged commit 31f4cc3 into dev Oct 13, 2025
4 checks passed
@staudtMarius staudtMarius deleted the df/#1562-pThermalMaxStorage branch October 13, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@staudtMarius staudtMarius staudtMarius approved these changes

Assignees

@danielfeismann danielfeismann

Labels

bug Something isn't working

Projects

None yet

Milestone

Version 4.1

Development

Successfully merging this pull request may close these issues.

Include some check that pThermalMax of storages is same or bigger as pThermal from the heat source

2 participants

@danielfeismann @staudtMarius