Refactor ThermalGrid.handleFeedIn #1555
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the ThermalGrid.handleFeedIn method by extracting complex conditional logic into separate, reusable components using the Strategy pattern.
- Introduced
ThermalDemandConditionsto encapsulate thermal demand state evaluation - Created
FeedInStrategypattern with concrete strategies for different heating scenarios - Replaced inline conditional logic with structured strategy selection
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ThermalStrategyPatterns.scala | Defines FeedInStrategy interface and three concrete strategy implementations |
| ThermalGrid.scala | Refactors handleFeedIn method to use strategy pattern and demand conditions |
| ThermalDemandConditions.scala | Encapsulates thermal demand state evaluation logic |
| CHANGELOG.md | Documents the refactoring changes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/main/scala/edu/ie3/simona/model/thermal/ThermalDemandConditions.scala
Outdated
Show resolved
Hide resolved
src/main/scala/edu/ie3/simona/model/thermal/ThermalDemandConditions.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
staudtMarius
requested changes
Oct 1, 2025
src/main/scala/edu/ie3/simona/model/thermal/ThermalDemandConditions.scala
Outdated
Show resolved
Hide resolved
src/main/scala/edu/ie3/simona/model/thermal/ThermalDemandConditions.scala
Outdated
Show resolved
Hide resolved
Comment on lines
+12
to
+19
| private case class ThermalDemandConditions( | ||
| shouldContinueHouseHeating: Boolean, | ||
| houseDemand: Boolean, | ||
| heatStorageDemand: Boolean, | ||
| housePossible: Boolean, | ||
| heatStoragePossible: Boolean, | ||
| houseHeatedLastState: Boolean, | ||
| ) |
There was a problem hiding this comment.
Maybe you could add some scaladoc here.
There was a problem hiding this comment.
No, it's private case class and I guess this should be quite clear as it is. Isn't it?
src/main/scala/edu/ie3/simona/model/thermal/ThermalStrategyPatterns.scala
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.