Skip to content

dreambooth: fix #1566: maintain fp32 wrapper when saving a checkpoint to avoid crash when running fp16 #1567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
timh wants to merge 2 commits into from
Closed

dreambooth: fix #1566: maintain fp32 wrapper when saving a checkpoint to avoid crash when running fp16 #1567

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3922b5
dreambooth: fix #1566: maintain fp32 wrapper when saving a checkpoint…
timh Dec 6, 2022
053e6b7
dreambooth: guard against passing keep_fp32_wrapper arg to older vers…
timh Dec 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions examples/dreambooth/train_dreambooth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import argparse
import hashlib
import inspect
import itertools
import math
import os
Expand Down Expand Up @@ -680,10 +681,18 @@ def main(args):

if global_step % args.save_steps == 0:
if accelerator.is_main_process:
# newer versions of accelerate allow the 'keep_fp32_wrapper' arg. without passing
# it, the models will be unwrapped, and when they are then used for further training,
# we will crash. pass this, but only to newer versions of accelerate. fixes
# https://github.com/huggingface/diffusers/issues/1566
accepts_keep_fp32_wrapper = "keep_fp32_wrapper" in set(
inspect.signature(accelerator.unwrap_model).parameters.keys()
)
extra_args = {"keep_fp32_wrapper": True} if accepts_keep_fp32_wrapper else {}
pipeline = DiffusionPipeline.from_pretrained(
args.pretrained_model_name_or_path,
unet=accelerator.unwrap_model(unet),
text_encoder=accelerator.unwrap_model(text_encoder),
unet=accelerator.unwrap_model(unet, **extra_args),
text_encoder=accelerator.unwrap_model(text_encoder, **extra_args),
revision=args.revision,
)
save_path = os.path.join(args.output_dir, f"checkpoint-{global_step}")
Expand Down