dreambooth: fix #1566: maintain fp32 wrapper when saving a checkpoint to avoid crash when running fp16 #1567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
patil-suraj
approved these changes
Dec 6, 2022
Contributor
patil-suraj
left a comment
patil-suraj
left a comment
There was a problem hiding this comment.
Thanks a lot for fixing this, just left one comment !
Comment on lines
679
to
680
| unet=accelerator.unwrap_model(unet, True), | ||
| text_encoder=accelerator.unwrap_model(text_encoder, True), |
Contributor
There was a problem hiding this comment.
Great catch!
The keep_fp32_wrapper argument was added only recently to accelerate.unwrap_model , so here we should first check if the method accepts that argument to keep compatibility with previous versions of accelerate.
It could be done with
accepts_keep_fp32_wrapper = "keep_fp32_wrapper" in set(inspect.signature(accelerator.unwrap_model().parameters.keys())
Contributor
Author
|
Changes made as you suggested. ICYMI, there's also a different PR with an alternative approach for fixing this issue: #1575 |
… checkpoint to avoid crash when running fp16
…ions of accelerate. part of fix for huggingface#1566
Contributor
Author
|
closing this one in favor of #1618, to make the merge commit nicer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.