Fixed Document with Proxied Fields Deletion Logic for EmbeddedDocuments #496
Conversation
Turns out DocumentMetaclass was the wrong place for this logic since EmbeddedDocuments did not have the same rights as regular Documents. This patch moves the logic to TopLevelDocumentMetaclass, and forces the proxied field detection to recurse through embedded document fields.
|
Great patch, however, I think we might want to clean / abstract this more. The FileField could theoretically be n levels down or in a ListField, so potentially we have to recurse and if thats the case it would be good to have a cleaner more performant way of doing it, as most documents wont have FileFields. I probably rushed in the initial implementation, I think we should revisit the approach as there must be a cleaner way to deal with this and possibly drop_collection, potentially storing meta data in the fs.files collection. |
|
Ok I'm going to revert the previous .delete() patch on the document and mark this as wont fix. I will open a new ticket to improve / drop_collection, document.delete() and Doc.objects.delete() all in one go. That will be done for 0.7 |
|
See MongoEngine#18 |
2 participants
As pointed out in #492 (comment)
FileFieldandImageFielddeletion breaks inEmbeddedDocuments. This set of patches build on pull request 492 to recurse through the fields of anEmbeddedDocumentto do the appropriate deletion there as well.