Cleanup referenced GridFS files when a document is deleted #492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that drop_collection is not modified since there is no guarantee that a GridFS collection holds files for only one Document class. Otherwise you could drop files for other fields or documents accidentally.
|
I have a similar patch that does a db.drop_collection() on the .files and .chunks collections for proxies, but I couldn't come up with a good way to guarantee that the collection was unique to a single field and wouldn't take out any other documents. I guess I could start a new issue if people want to talk about this, otherwise people will leak files if they drop_collection(). |
rozza
referenced
this pull request
in MongoEngine/mongoengine
May 9, 2012
|
Thanks for the patch! It'll be in 0.6.8 due end of play today :) |
|
It fails when a FileField is in an EmbeddedDocument because EmbeddedDocument lacks of 'register_proxy_field' method. |
|
Great catch! See #496 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that drop_collection is not modified since there is no
guarantee that a GridFS collection holds files for only one
Document class. Otherwise you could drop files for other fields
or documents accidentally.