Use go-enry for language detection #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleh-null
reviewed
Oct 1, 2024
Collaborator
aleh-null
left a comment
aleh-null
left a comment
There was a problem hiding this comment.
Really nice! I wonder if we really need to pinpoint main language in a repo, I like the way do count for each language.
cmd/run.go
Outdated
| lspServerExecutables[lsp.LanguageId("python")] = lsp.NewCommand("pyright-langserver", []string{"--stdio"}) | ||
| lspServerExecutables[lsp.LanguageId("javascript")] = lsp.NewCommand("typescript-language-server", []string{"--stdio"}) | ||
| lspServerExecutables[lsp.LanguageId("typescript")] = lsp.NewCommand("typescript-language-server", []string{"--stdio"}) | ||
| lspServerExecutables[lsp.Go] = lsp.NewCommand("gopls", []string{}) |
Collaborator
There was a problem hiding this comment.
I think we should move all this logic to lsp pkg. Something like lsp.Excecutables() map[lsp.LanguageId]lsp.Command
Collaborator
Author
we don't really pin it. we just need to know which lsp server to start. |
aleh-null
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #115 where the project language was detected incorrectly. The previous language detection algorithm naively counted file extensions and returned the language corresponding to the most popular file extension.
The new algorithm is based on https://github.com/go-enry/go-enry, SOTA for language detection. The language of the file is detected by
enryand the project language is defined as the language having most bytes, not just files. This algorithm is still not ideal but it's good enough and corresponds to how GitHub detects languages for the repos.I tested it on the reported repo
djangoand it was accurate.