search_symbols fails with None is not iterable

[wistuba]

Hello! First of all, great work you are doing, I really love it!

I've tried your new search_symbols feature and it seems to work in general, but apparently not in all cases and it is not clear why.

The content of the response is None such that json() returns None which is not iterable so it fails: https://github.com/hide-org/hide-sdk/blob/main/hide/client/hide_client.py#L197

https://github.com/django/django/ is one repository where I see that it fails. I assume this is related to some problem with the LSP. I see that warning, but it probably is not my setup. Other Python repositories work fine for me. Any idea what might cause this?

[artmoskvin]

hey! thanks for reporting. i think the problem here is us not handling empty lsp responses properly.

i assume that for symbol search when nothing is found lsp returns None and we simply forward it as an API response.

i will try to reproduce this bug and get back to you. what query did you use?

[wistuba]

That does not seem to be the case. In the other cases, it comes back to me even in these cases. Example queries: "test", "__init__".

[artmoskvin]

Sorry it took me so long but I see what's the problem now. hide fails to detect the main language for Django is Python. I suspect there's a flaw in our language detection algorithm. I'm looking at it now.

[wistuba]

Great news! Would it be possible to manually select the language as well?

Some pointers that might avoid creating your own detector: this seems to be the language detector used for Github https://github.com/github-linguist/linguist There is a Go port, but that doesn't seem to be maintained anymore: https://github.com/dayvonjersen/linguist

[prabhuteja12]

Would it be possible to provide the language as an argument in the create_project call?

[artmoskvin]

For Go, there's even a better one https://github.com/go-enry/go-enry It's faster and also based on Linguist. I'm working on integrating it right now.

[artmoskvin]

Would it be possible to provide the language as an argument in the create_project call?

Yeah that's another option which we probably should provide. Let me integrate go-enry first, I'm half way there. Then we'll consider adding a language argument in the create project request.

[artmoskvin]

We got go-enry integrated now. The language detection should work a lot better now. I tried creating a project for django and it worked perfectly. Check it out and let us know how it works!

Looking into adding the languages argument in the create project request.

[wistuba]

I can confirm that it works for django now. I still face the same issues with other repositories, e.g., https://github.com/sphinx-doc/sphinx

I assume this is the related error message Failed to start LSP server. Diagnostics will not be available. error="Language Gettext Catalog is not supported"

[artmoskvin]

thanks for confirming. it seems the language detector picks the wrong language again. i think we’ll prioritize adding the language parameter in the create project request to unblock you and then tweak the detection algorithm. 

[wistuba]

Thank you, that would be great!

[artmoskvin]

adding the languages parameter here #125
should go live today or tomorrow