Revert "core: pass Subchannel state updates to SubchannelStateListene… #5684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@voidzcy, this will break #5639. Don't try to fix it yet. I will re-introduce /cc @dapengzhang0 |
ejona86
approved these changes
May 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r rather than LoadBalancer (#5503)"
This reverts commit 62b03fd.
Effectively reverts its follow-up commits:
dc218b6
405d8c3
44840fe
In order to fix #5676, we need to make a tweak to
SubchannelStateListenerand some other APIs. Since it has never been in any releases, it's better to avoid it in the upcoming 1.21 so that we don't have to deal with yet another migration.