-
Notifications
You must be signed in to change notification settings - Fork 4k
xds: implement lb policy backend metric api #5639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xds: implement lb policy backend metric api #5639
Conversation
a26bf96 to
420a6df
Compare
420a6df to
b92463e
Compare
13911a3 to
f07391a
Compare
3351346 to
4b238ea
Compare
642cdae to
742faf7
Compare
Codecov Report
@@ Coverage Diff @@
## master #5639 +/- ##
============================================
- Coverage 82.38% 82.36% -0.03%
+ Complexity 3207 3203 -4
============================================
Files 265 265
Lines 17031 17031
Branches 2001 2001
============================================
- Hits 14031 14027 -4
- Misses 2209 2210 +1
- Partials 791 794 +3
Continue to review full report at Codecov.
|
ddf3caa to
66e5545
Compare
46d2697 to
cdaea7a
Compare
zhangkun83
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely written! Some minor comments.
… OrcaReportListener installed for retrieving per-request ORCA data
…most helper in the wrapping structure
…or per-request and out-of-band cases
…et rid of static methods for easier user testing
…rresponding OrcaOobReportListener registered are passed to the listener callback
…ow ties with Subchannel)
32d97e8 to
2f9f6bb
Compare
Summary:
Implemented two utility classes for clients to access ORCA backend metric.
OrcaPerRequestUtilprovides methods to interceptClientStreamTracer.Factorywith a listener registered to receive per-request ORCA reports.OrcaOobUtilprovides methods to interceptLoadBalancer.Helperwith a listener registered to receive out-of-band ORCA reports.Internal design doc is at
go/grpc-lb-policy-backend-metric-api-java