Skip to content

Conversation

@voidzcy
Copy link
Contributor

@voidzcy voidzcy commented Apr 25, 2019

Summary:


Implemented two utility classes for clients to access ORCA backend metric.

OrcaPerRequestUtil provides methods to intercept ClientStreamTracer.Factory with a listener registered to receive per-request ORCA reports.
OrcaOobUtil provides methods to intercept LoadBalancer.Helper with a listener registered to receive out-of-band ORCA reports.

Internal design doc is at go/grpc-lb-policy-backend-metric-api-java

@voidzcy voidzcy force-pushed the feature/lb_orca_metric_api_impl branch from a26bf96 to 420a6df Compare April 25, 2019 18:11
@voidzcy voidzcy force-pushed the feature/lb_orca_metric_api_impl branch from 420a6df to b92463e Compare April 25, 2019 18:40
@voidzcy voidzcy requested a review from zhangkun83 April 25, 2019 18:40
@voidzcy voidzcy marked this pull request as ready for review April 25, 2019 18:40
@voidzcy voidzcy force-pushed the feature/lb_orca_metric_api_impl branch 3 times, most recently from 13911a3 to f07391a Compare April 25, 2019 20:45
@voidzcy voidzcy changed the title xds: implement per-request lb policy backend metric api WIP: implement lb policy backend metric api Apr 25, 2019
@voidzcy voidzcy force-pushed the feature/lb_orca_metric_api_impl branch 2 times, most recently from 3351346 to 4b238ea Compare April 25, 2019 23:51
@voidzcy voidzcy force-pushed the feature/lb_orca_metric_api_impl branch 4 times, most recently from 642cdae to 742faf7 Compare May 3, 2019 01:21
@voidzcy voidzcy changed the title WIP: implement lb policy backend metric api xds: implement lb policy backend metric api May 3, 2019
@voidzcy voidzcy requested review from dapengzhang0 and zhangkun83 May 3, 2019 19:48
@codecov
Copy link

codecov bot commented May 7, 2019

Codecov Report

Merging #5639 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5639      +/-   ##
============================================
- Coverage     82.38%   82.36%   -0.03%     
+ Complexity     3207     3203       -4     
============================================
  Files           265      265              
  Lines         17031    17031              
  Branches       2001     2001              
============================================
- Hits          14031    14027       -4     
- Misses         2209     2210       +1     
- Partials        791      794       +3
Impacted Files Coverage Δ Complexity Δ
.../src/main/java/io/grpc/EquivalentAddressGroup.java 66.66% <0%> (-7.41%) 10% <0%> (-1%)
...rc/main/java/io/grpc/netty/NettyClientHandler.java 87.68% <0%> (-0.91%) 55% <0%> (-2%)
...rc/main/java/io/grpc/netty/NettyServerHandler.java 80.58% <0%> (-0.27%) 49% <0%> (-1%)
...ain/java/io/grpc/inprocess/InProcessTransport.java 90.19% <0%> (+0.54%) 31% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54a9a15...95e72b2. Read the comment docs.

Copy link
Contributor

@zhangkun83 zhangkun83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely written! Some minor comments.

voidzcy added 22 commits May 23, 2019 15:43
…et rid of static methods for easier user testing
…rresponding OrcaOobReportListener registered are passed to the listener callback
@voidzcy voidzcy force-pushed the feature/lb_orca_metric_api_impl branch from 32d97e8 to 2f9f6bb Compare May 24, 2019 00:01
@voidzcy voidzcy requested a review from zhangkun83 May 24, 2019 00:11
@voidzcy voidzcy merged commit 7fd5f26 into grpc:master May 24, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants