-
Notifications
You must be signed in to change notification settings - Fork 4k
cronet : Update library + Move to StableAPIs in Cronet #11068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3e98f90 to
0c0d19e
Compare
|
Hi @sergiitk, I was just wondering on Linux and Macos artifacts taking time (those are stalled for ~10 days), does it signify any problem in the builds ? or are we supposed to generate and add them ? |
ejona86
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me, but I'm not sure if enough Android devices have the stable API. We may need to fall-back to the experimental API to reach more devices. @temawi, would you be able to investigate that?
cronet/src/test/java/io/grpc/cronet/CronetClientStreamTest.java
Outdated
Show resolved
Hide resolved
It's not a problem. We have to manually start those builds by adding that kokoro label. |
2838767 to
9cd9cb3
Compare
I agree to this, Adding little-bit of background :
|
9cd9cb3 to
94cd1d5
Compare
I also checked with the Cronet team - this should be a safe change to make. |
ejona86
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@temawi, given the commits are split out, we'll probably want to rebase this instead of squashing (ideally the commits would have cronet: prefixes to make scanning easier, but this is fine).
…(deprecated) => UPDATE_DEVICE_STATS
94cd1d5 to
cb2e1af
Compare
Updated commits with |
|
@Ashok-Varma, see the milestones. Minor releases are scheduled every six weeks. |
In this Pull Request
119.6045.31from108.5359.79, In which Experimental API's are deprecated and moved to Stable Interfaces.Minor Changes
MODIFY_NETWORK_ACCOUNTING(deprecated) toUPDATE_DEVICE_STATSCharset.forName("UTF-8")toStandardCharsets.UTF_8StandardFixes #10396 (@sergiitk)