grpc-cronet: ExperimentalBidirectionalStream, ExperimentalCronetEngine are deprecated #10396
Description
I Attempted updating cronet dependencies in #10359:
org.chromium.net:cronet-api 108.5359.79 -> 113.5672.61
org.chromium.net:cronet-embedded 108.5359.79 -> 113.5672.61
Gradle build failed with various deprecation warnings:
gradle build log
(shortened repeated warnings)
> Task :grpc-cronet:compileDebugJavaWithJavac
cronet/src/main/java/io/grpc/cronet/CronetChannelBuilder.java:50: warning: [deprecation] ExperimentalBidirectionalStream in org.chromium.net has been deprecated
import org.chromium.net.ExperimentalBidirectionalStream;
^
cronet/src/main/java/io/grpc/cronet/CronetChannelBuilder.java:51: warning: [deprecation] ExperimentalCronetEngine in org.chromium.net has been deprecated
import org.chromium.net.ExperimentalCronetEngine;
^
cronet/src/main/java/io/grpc/cronet/CronetClientStream.java:58: warning: [deprecation] ExperimentalBidirectionalStream in org.chromium.net has been deprecated
import org.chromium.net.ExperimentalBidirectionalStream;
^
cronet/src/main/java/io/grpc/cronet/CronetChannelBuilder.java:320: warning: [deprecation] ExperimentalBidirectionalStream in org.chromium.net has been deprecated
ExperimentalBidirectionalStream.Builder builder =
^
cronet/src/main/java/io/grpc/cronet/CronetChannelBuilder.java:320: warning: [deprecation] Builder in ExperimentalBidirectionalStream has been deprecated
ExperimentalBidirectionalStream.Builder builder =
^
cronet/src/main/java/io/grpc/cronet/CronetChannelBuilder.java:321: warning: [deprecation] ExperimentalCronetEngine in org.chromium.net has been deprecated
((ExperimentalCronetEngine) cronetEngine)
^
cronet/src/main/java/io/grpc/cronet/CronetChannelBuilder.java:332: warning: [deprecation] ExperimentalBidirectionalStream in org.chromium.net has been deprecated
private static void setTrafficStatsTag(ExperimentalBidirectionalStream.Builder builder,
^
cronet/src/main/java/io/grpc/cronet/CronetChannelBuilder.java:332: warning: [deprecation] Builder in ExperimentalBidirectionalStream has been deprecated
private static void setTrafficStatsTag(ExperimentalBidirectionalStream.Builder builder,
^
cronet/src/main/java/io/grpc/cronet/CronetChannelBuilder.java:338: warning: [deprecation] ExperimentalBidirectionalStream in org.chromium.net has been deprecated
setTrafficStatsTagMethod = ExperimentalBidirectionalStream.Builder.class
^
cronet/src/main/java/io/grpc/cronet/CronetChannelBuilder.java:338: warning: [deprecation] Builder in ExperimentalBidirectionalStream has been deprecated
setTrafficStatsTagMethod = ExperimentalBidirectionalStream.Builder.class
^
cronet/src/main/java/io/grpc/cronet/CronetChannelBuilder.java:361: warning: [deprecation] ExperimentalBidirectionalStream in org.chromium.net has been deprecated
private static void setTrafficStatsUid(ExperimentalBidirectionalStream.Builder builder,
^
cronet/src/main/java/io/grpc/cronet/CronetChannelBuilder.java:361: warning: [deprecation] Builder in ExperimentalBidirectionalStream has been deprecated
private static void setTrafficStatsUid(ExperimentalBidirectionalStream.Builder builder,
^
cronet/src/main/java/io/grpc/cronet/CronetChannelBuilder.java:367: warning: [deprecation] ExperimentalBidirectionalStream in org.chromium.net has been deprecated
setTrafficStatsUidMethod = ExperimentalBidirectionalStream.Builder.class
^
cronet/src/main/java/io/grpc/cronet/CronetChannelBuilder.java:367: warning: [deprecation] Builder in ExperimentalBidirectionalStream has been deprecated
setTrafficStatsUidMethod = ExperimentalBidirectionalStream.Builder.class
^
cronet/src/main/java/io/grpc/cronet/CronetClientStream.java:196: warning: [deprecation] ExperimentalBidirectionalStream in org.chromium.net has been deprecated
ExperimentalBidirectionalStream.Builder expBidiStreamBuilder =
^
cronet/src/main/java/io/grpc/cronet/CronetClientStream.java:196: warning: [deprecation] Builder in ExperimentalBidirectionalStream has been deprecated
ExperimentalBidirectionalStream.Builder expBidiStreamBuilder =
^
cronet/src/main/java/io/grpc/cronet/CronetClientStream.java:197: warning: [deprecation] ExperimentalBidirectionalStream in org.chromium.net has been deprecated
(ExperimentalBidirectionalStream.Builder) builder;
^
cronet/src/main/java/io/grpc/cronet/CronetClientStream.java:197: warning: [deprecation] Builder in ExperimentalBidirectionalStream has been deprecated
(ExperimentalBidirectionalStream.Builder) builder;
^
cronet/src/main/java/io/grpc/cronet/CronetClientStream.java:369: warning: [deprecation] ExperimentalBidirectionalStream in org.chromium.net has been deprecated
private static void addRequestAnnotation(ExperimentalBidirectionalStream.Builder builder,
^
cronet/src/main/java/io/grpc/cronet/CronetClientStream.java:369: warning: [deprecation] Builder in ExperimentalBidirectionalStream has been deprecated
private static void addRequestAnnotation(ExperimentalBidirectionalStream.Builder builder,
^
cronet/src/main/java/io/grpc/cronet/CronetClientStream.java:375: warning: [deprecation] ExperimentalBidirectionalStream in org.chromium.net has been deprecated
addRequestAnnotationMethod = ExperimentalBidirectionalStream.Builder.class
^
cronet/src/main/java/io/grpc/cronet/CronetClientStream.java:375: warning: [deprecation] Builder in ExperimentalBidirectionalStream has been deprecated
addRequestAnnotationMethod = ExperimentalBidirectionalStream.Builder.class
^
22 warnings
> Task :grpc-cronet:compileDebugUnitTestJavaWithJavac
cronet/src/test/java/io/grpc/cronet/CronetClientStreamTest.java:57: warning: [deprecation] ExperimentalBidirectionalStream in org.chromium.net has been deprecated
import org.chromium.net.ExperimentalBidirectionalStream;
^
cronet/src/test/java/io/grpc/cronet/CronetChannelBuilderTest.java:38: warning: [deprecation] ExperimentalCronetEngine in org.chromium.net has been deprecated
import org.chromium.net.ExperimentalCronetEngine;
^
cronet/src/test/java/io/grpc/cronet/CronetClientStreamTest.java:79: warning: [deprecation] ExperimentalBidirectionalStream in org.chromium.net has been deprecated
@Mock private ExperimentalBidirectionalStream cronetStream;
^
cronet/src/test/java/io/grpc/cronet/CronetClientStreamTest.java:81: warning: [deprecation] ExperimentalBidirectionalStream in org.chromium.net has been deprecated
@Mock private ExperimentalBidirectionalStream.Builder builder;
^
cronet/src/test/java/io/grpc/cronet/CronetClientStreamTest.java:81: warning: [deprecation] Builder in ExperimentalBidirectionalStream has been deprecated
@Mock private ExperimentalBidirectionalStream.Builder builder;
^
cronet/src/test/java/io/grpc/cronet/CronetClientStreamTest.java:684: warning: [deprecation] ExperimentalBidirectionalStream in org.chromium.net has been deprecated
ExperimentalBidirectionalStream.Builder getBuilder =
^
cronet/src/test/java/io/grpc/cronet/CronetClientStreamTest.java:684: warning: [deprecation] Builder in ExperimentalBidirectionalStream has been deprecated
ExperimentalBidirectionalStream.Builder getBuilder =
^
cronet/src/test/java/io/grpc/cronet/CronetClientStreamTest.java:685: warning: [deprecation] ExperimentalBidirectionalStream in org.chromium.net has been deprecated
mock(ExperimentalBidirectionalStream.Builder.class);
^
cronet/src/test/java/io/grpc/cronet/CronetClientStreamTest.java:685: warning: [deprecation] Builder in ExperimentalBidirectionalStream has been deprecated
mock(ExperimentalBidirectionalStream.Builder.class);
^
cronet/src/test/java/io/grpc/cronet/CronetClientStreamTest.java:741: warning: [deprecation] ExperimentalBidirectionalStream in org.chromium.net has been deprecated
ExperimentalBidirectionalStream.Builder builder =
^
cronet/src/test/java/io/grpc/cronet/CronetClientStreamTest.java:741: warning: [deprecation] Builder in ExperimentalBidirectionalStream has been deprecated
ExperimentalBidirectionalStream.Builder builder =
^
cronet/src/test/java/io/grpc/cronet/CronetClientStreamTest.java:742: warning: [deprecation] ExperimentalBidirectionalStream in org.chromium.net has been deprecated
mock(ExperimentalBidirectionalStream.Builder.class);
^
cronet/src/test/java/io/grpc/cronet/CronetClientStreamTest.java:742: warning: [deprecation] Builder in ExperimentalBidirectionalStream has been deprecated
mock(ExperimentalBidirectionalStream.Builder.class);
^
cronet/src/test/java/io/grpc/cronet/CronetClientStreamTest.java:773: warning: [deprecation] ExperimentalBidirectionalStream in org.chromium.net has been deprecated
ExperimentalBidirectionalStream.Builder builder =
^
cronet/src/test/java/io/grpc/cronet/CronetClientStreamTest.java:773: warning: [deprecation] Builder in ExperimentalBidirectionalStream has been deprecated
ExperimentalBidirectionalStream.Builder builder =
^
cronet/src/test/java/io/grpc/cronet/CronetClientStreamTest.java:774: warning: [deprecation] ExperimentalBidirectionalStream in org.chromium.net has been deprecated
mock(ExperimentalBidirectionalStream.Builder.class);
^
cronet/src/test/java/io/grpc/cronet/CronetClientStreamTest.java:774: warning: [deprecation] Builder in ExperimentalBidirectionalStream has been deprecated
mock(ExperimentalBidirectionalStream.Builder.class);
^
cronet/src/test/java/io/grpc/cronet/CronetClientStreamTest.java:813: warning: [deprecation] ExperimentalBidirectionalStream in org.chromium.net has been deprecated
ExperimentalBidirectionalStream.Builder builder =
^
cronet/src/test/java/io/grpc/cronet/CronetClientStreamTest.java:813: warning: [deprecation] Builder in ExperimentalBidirectionalStream has been deprecated
ExperimentalBidirectionalStream.Builder builder =
^
cronet/src/test/java/io/grpc/cronet/CronetClientStreamTest.java:814: warning: [deprecation] ExperimentalBidirectionalStream in org.chromium.net has been deprecated
mock(ExperimentalBidirectionalStream.Builder.class);
^
cronet/src/test/java/io/grpc/cronet/CronetClientStreamTest.java:814: warning: [deprecation] Builder in ExperimentalBidirectionalStream has been deprecated
mock(ExperimentalBidirectionalStream.Builder.class);
^
cronet/src/test/java/io/grpc/cronet/CronetChannelBuilderTest.java:53: warning: [deprecation] ExperimentalCronetEngine in org.chromium.net has been deprecated
@Mock private ExperimentalCronetEngine mockEngine;
^
22 warningsSteps to reproduce the bug
Apply patch:
diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml
index 7217d560a..b022132a9 100644
--- a/gradle/libs.versions.toml
+++ b/gradle/libs.versions.toml
@@ -36,8 +36,8 @@ auto-value-annotations = "com.google.auto.value:auto-value-annotations:1.10.2"
checkstyle = "com.puppycrawl.tools:checkstyle:10.12.1"
commons-math3 = "org.apache.commons:commons-math3:3.6.1"
conscrypt = "org.conscrypt:conscrypt-openjdk-uber:2.5.2"
-cronet-api = "org.chromium.net:cronet-api:108.5359.79"
-cronet-embedded = "org.chromium.net:cronet-embedded:108.5359.79"
+cronet-api = "org.chromium.net:cronet-api:113.5672.61"
+cronet-embedded = "org.chromium.net:cronet-embedded:113.5672.61"
errorprone-annotations = "com.google.errorprone:error_prone_annotations:2.20.0"
errorprone-core = "com.google.errorprone:error_prone_core:2.20.0"
google-api-protos = "com.google.api.grpc:proto-google-common-protos:2.22.0"
Then do gradle build.