Skip to content

Conversation

@chris-ramon
Copy link
Member

Details

Test Plan

✔️ Via unit tests & CI.

@chris-ramon chris-ramon self-assigned this Jul 28, 2025
@mentatbot
Copy link

mentatbot bot commented Jul 28, 2025

I'm getting to work. See my steps and track my cost here.

  • Wake on any new activity.
    I always see new activity while actively working. When paused, I'll only respond when tagged unless this box is checked. Learn more about triggers.

@chris-ramon
Copy link
Member Author

LGTM 👍 🚢

@chris-ramon chris-ramon merged commit fd79992 into master Jul 28, 2025
6 checks passed
@chris-ramon chris-ramon deleted the issue-726 branch July 28, 2025 11:40
@mentatbot
Copy link

mentatbot bot commented Jul 28, 2025

I noticed this PR was just merged, but I found a grammatical issue that was introduced:

The change from:

"If this server supports subscription, the type that ..."

to:

"If this server support subscription, the type that ..."  

is actually incorrect grammar. The subject "server" is singular, so it requires the third-person singular verb form "supports", not "support".

The original text was grammatically correct. This change makes the grammar worse, not better.

Since this is already merged, we should create a follow-up PR to fix this back to "supports subscription" to maintain proper grammar.

The other changes in the PR (adding the period to the enum description, fixing "a object" → "an object type definition", and cleaning up whitespace) were all good improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

{introspection}: Grammar fixes.

2 participants