Add Git patch for upstream graphql-go grammar fixes #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch addresses the grammar and punctuation issues identified in the validator compatibility adjustments: 1. Fix grammar: "a object definition" → "an object type definition" 2. Fix grammar: "supports subscription" → "support subscription" (to match graphql-js reference) 3. Add missing period to TypeKind enum description 4. Remove extra space before newline in Directive description 5. Update corresponding test expectations The patch can be applied to the graphql-go repository to eliminate the need for these specific compatibility adjustments in the validator. Co-authored-by: chris-ramon <[email protected]>
Member
|
Closed via: graphql-go/graphql#727. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Git patch file that addresses the grammar and punctuation issues identified in the validator's compatibility adjustments.
The patch fixes the following issues in the graphql-go repository:
__Typeis" → "An enum describing what kind of type a given__Typeis."Once this patch is applied to the graphql-go repository, the specific text normalization rules in the validator's
normalizeStringFieldsfunction can be removed, reducing the need for ad-hoc compatibility adjustments.The patch file
graphql-go-grammar-fixes.patchcan be applied usinggit applyorgit amin the graphql-go repository.Closes #61
🤖 This PR was created with Mentat. See my steps and cost here ✨