Skip to content

Conversation

@arriolac
Copy link
Contributor

@arriolac arriolac commented Aug 13, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #743 🦕

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 13, 2021
@snippet-bot
Copy link

snippet-bot bot commented Sep 15, 2021

Here is the summary of changes.

You are about to add 1 region tag.
You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@arriolac arriolac force-pushed the chris/feat/experience_id_request branch from 0c36e14 to 3cc393b Compare September 15, 2021 18:23
@arriolac arriolac force-pushed the chris/feat/experience_id_request branch from 3cc393b to 7a28328 Compare September 15, 2021 18:34
@codecov-commenter
Copy link

Codecov Report

Merging #744 (eb606c7) into main (9852dba) will increase coverage by 0.05%.
The diff coverage is 74.35%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #744      +/-   ##
============================================
+ Coverage     67.67%   67.72%   +0.05%     
- Complexity      541      544       +3     
============================================
  Files           136      136              
  Lines          3004     3018      +14     
  Branches        292      292              
============================================
+ Hits           2033     2044      +11     
- Misses          814      817       +3     
  Partials        157      157              
Impacted Files Coverage Δ
...c/main/java/com/google/maps/GaeRequestHandler.java 0.00% <0.00%> (ø)
...ain/java/com/google/maps/internal/HttpHeaders.java 0.00% <ø> (ø)
...c/main/java/com/google/maps/PendingResultBase.java 70.00% <70.00%> (-1.43%) ⬇️
src/main/java/com/google/maps/GeoApiContext.java 61.18% <94.11%> (+0.11%) ⬆️
...ain/java/com/google/maps/OkHttpRequestHandler.java 65.45% <100.00%> (+5.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53ff14a...eb606c7. Read the comment docs.

@arriolac arriolac changed the title feat: Support setting experienceIds on a per request basis. feat!: Support setting experienceIds on a per request basis. Sep 15, 2021
@arriolac arriolac merged commit 325b67e into main Sep 15, 2021
@arriolac arriolac deleted the chris/feat/experience_id_request branch September 15, 2021 20:34
googlemaps-bot pushed a commit that referenced this pull request Sep 15, 2021
# [1.0.0](v0.19.0...v1.0.0) (2021-09-15)

* feat!: Support setting experienceIds on a per request basis. (#744) ([325b67e](325b67e)), closes [#744](#744)

### BREAKING CHANGES

* Setting an experience ID is now done on a per-request basis vs. setting it on the GeoApiContext object.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support setting experienceId per request

2 participants