Skip to content

samples: delete unspecified sample #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 16, 2021
Merged

samples: delete unspecified sample #671

merged 3 commits into from
Dec 16, 2021

Conversation

shaffeeullah
Copy link
Contributor

No description provided.

@shaffeeullah shaffeeullah requested review from a team as code owners December 16, 2021 17:56
@shaffeeullah shaffeeullah requested a review from engelke December 16, 2021 17:56
@snippet-bot
Copy link

snippet-bot bot commented Dec 16, 2021

Here is the summary of changes.

You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: storage Issues related to the googleapis/python-storage API. samples Issues that are directly related to samples. labels Dec 16, 2021
@shaffeeullah shaffeeullah requested a review from cojenco December 16, 2021 17:56
@cojenco
Copy link
Contributor

cojenco commented Dec 16, 2021 •
edited
Loading

@shaffeeullah Could you help update the samples/README, specifically delete lines 140 and 980-988, thanks!!

@shaffeeullah
Copy link
Contributor Author

@cojenco updated! sorry I always forget about the README in python. node.js has a bot that does this stuff for us and ive gotten super used to it

cojenco
cojenco approved these changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@cojenco cojenco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@shaffeeullah shaffeeullah merged commit 0e1a0ff into googleapis:main Dec 16, 2021
@shaffeeullah shaffeeullah deleted the shaffeeullah/deleteUnspecifiedSample branch December 16, 2021 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cojenco cojenco cojenco approved these changes

@engelke engelke Awaiting requested review from engelke engelke was automatically assigned from googleapis/python-samples-owners

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/python-storage API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shaffeeullah @cojenco