Skip to content

Commit 0e1a0ff

Browse files
authored
samples: delete unspecified sample (#671)
* samples: delete unspecified sample * fixed lint issue * updated readme
1 parent ceb9314 commit 0e1a0ff

File tree

3 files changed

+0
-64
lines changed

3 files changed

+0
-64
lines changed

samples/README.md

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,6 @@ for more detailed instructions.
137137
* [Set Metadata](#set-metadata)
138138
* [Set Public Access Prevention Enforced](#set-public-access-prevention-enforced)
139139
* [Set Public Access Prevention Inherited](#set-public-access-prevention-inherited)
140-
* [Set Public Access Prevention Unspecified](#set-public-access-prevention-unspecified)
141140
* [Set Retention Policy](#set-retention-policy)
142141
* [Set Temporary Hold](#set-temporary-hold)
143142
* [Upload Encrypted File](#upload-encrypted-file)
@@ -977,15 +976,6 @@ View the [source code](https://github.com/googleapis/python-storage/blob/main/sa
977976
978977
`python storage_set_public_access_prevention_inherited.py <BUCKET_NAME>`
979978
980-
-----
981-
### Set Public Access Prevention Unspecified
982-
[![Open in Cloud Shell][shell_img]](https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/googleapis/python-storage&page=editor&open_in_editor=samples/snippets/storage_set_public_access_prevention_unspecified.py,samples/README.md)
983-
984-
View the [source code](https://github.com/googleapis/python-storage/blob/main/samples/snippets/storage_set_public_access_prevention_unspecified.py). To run this sample:
985-
986-
987-
`python storage_set_public_access_prevention_unspecified.py <BUCKET_NAME>`
988-
989979
-----
990980
### Set Retention Policy
991981
[![Open in Cloud Shell][shell_img]](https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/googleapis/python-storage&page=editor&open_in_editor=samples/snippets/storage_set_retention_policy.py,samples/README.md)

samples/snippets/public_access_prevention_test.py

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,12 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15-
import pytest
1615

1716
import storage_get_public_access_prevention
1817
import storage_set_public_access_prevention_enforced
1918
import storage_set_public_access_prevention_inherited
20-
import storage_set_public_access_prevention_unspecified
2119

2220

23-
@pytest.mark.skip(reason="Inconsistent due to unspecified->inherited change")
2421
def test_get_public_access_prevention(bucket, capsys):
2522
short_name = storage_get_public_access_prevention
2623
short_name.get_public_access_prevention(bucket.name)
@@ -35,14 +32,6 @@ def test_set_public_access_prevention_enforced(bucket, capsys):
3532
assert f"Public access prevention is set to enforced for {bucket.name}." in out
3633

3734

38-
@pytest.mark.skip(reason="Inconsistent due to unspecified->inherited change")
39-
def test_set_public_access_prevention_unspecified(bucket, capsys):
40-
short_name = storage_set_public_access_prevention_unspecified
41-
short_name.set_public_access_prevention_unspecified(bucket.name)
42-
out, _ = capsys.readouterr()
43-
assert f"Public access prevention is 'unspecified' for {bucket.name}." in out
44-
45-
4635
def test_set_public_access_prevention_inherited(bucket, capsys):
4736
short_name = storage_set_public_access_prevention_inherited
4837
short_name.set_public_access_prevention_inherited(bucket.name)

samples/snippets/storage_set_public_access_prevention_unspecified.py

Lines changed: 0 additions & 43 deletions
This file was deleted.

0 commit comments

Comments
 (0)