Skip to content

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Oct 7, 2020

Update pbs_for_create, pbs_for_set_no_merge, pbs_for_set_with_merge, and pbs_for_update to match semantics expected by current versions of conformance tests:

  • Rather than create separate Write.transform messages to hold field transforms, inline them as update_transforms in the main Write.update message (which will always be created now).

Copy in the current version of the conftest JSON files and verify.

Closes #217

@tseaver tseaver requested review from a team, BenWhitehead and crwilcox October 7, 2020 17:43
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 7, 2020
@tseaver
Copy link
Contributor Author

tseaver commented Oct 7, 2020

Note to reviewers: commit-by-commit is likely easier than all-at-once: the last commit is just the "copy current JSON files" bit, which doesn't really need review.

@tseaver tseaver added the automerge Merge the pull request once unit tests and other checks pass. label Oct 10, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit c122e41 into master Oct 10, 2020
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 10, 2020
tseaver added a commit that referenced this pull request Oct 22, 2020
tseaver added a commit that referenced this pull request Oct 22, 2020
@tseaver tseaver deleted the 217-support-update_transforms branch December 7, 2021 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update cross-language conformance tests to latest spec

2 participants