Skip to content

Commit 8ed20f0

Browse files
committed
chore: remove unused 'allow_empty_mask' extractor arg
Residue from PR #219.
1 parent dcaa254 commit 8ed20f0

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

google/cloud/firestore_v1/_helpers.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -757,8 +757,7 @@ def _get_update_mask(
757757
if field_path not in self.transform_merge
758758
]
759759

760-
if mask_paths or allow_empty_mask:
761-
return common.DocumentMask(field_paths=mask_paths)
760+
return common.DocumentMask(field_paths=mask_paths)
762761

763762

764763
def pbs_for_set_with_merge(
@@ -780,10 +779,8 @@ def pbs_for_set_with_merge(
780779
extractor = DocumentExtractorForMerge(document_data)
781780
extractor.apply_merge(merge)
782781

783-
merge_empty = not document_data
784-
allow_empty_mask = merge_empty or extractor.transform_paths
782+
set_pb = extractor.get_update_pb(document_path)
785783

786-
set_pb = extractor.get_update_pb(document_path, allow_empty_mask=allow_empty_mask)
787784
if extractor.transform_paths:
788785
field_transform_pbs = extractor.get_field_transform_pbs(document_path)
789786
set_pb.update_transforms.extend(field_transform_pbs)

0 commit comments

Comments
 (0)