feat: add inline type hints #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
crwilcox
added
the
do not merge
rafilong
suggested changes
Aug 4, 2020
Contributor
rafilong
left a comment
rafilong
left a comment
There was a problem hiding this comment.
Some confusion regarding duplication and specific types.
This was referenced Aug 4, 2020
tseaver
reviewed
Aug 20, 2020
| from google.api_core import operation as ga_operation | ||
| from google.api_core import operation_async | ||
| from google.api_core import operation as ga_operation # type: ignore | ||
| from google.api_core import operation_async # type: ignore |
Contributor
There was a problem hiding this comment.
This is autogen code: how are we going to preserve this work?
| import nox | ||
|
|
||
|
|
||
| PYTYPE_VERSION = "pytype==2020.7.24" |
Contributor
There was a problem hiding this comment.
This change (and below) gets wiped out by synthtool.
| [bdist_wheel] | ||
| universal = 1 | ||
|
|
||
| [pytype] |
Contributor
There was a problem hiding this comment.
Likewise wiped out by synthtool.
| from typing import Tuple | ||
|
|
||
|
|
||
| __all__: Tuple[ |
Contributor
There was a problem hiding this comment.
Why a tuple? It would normally be List[str]?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.