-
Notifications
You must be signed in to change notification settings - Fork 83
Closed
Labels
api: firestoreIssues related to the googleapis/python-firestore API.Issues related to the googleapis/python-firestore API.good first issueThis issue is a good place to started contributing to this repository.This issue is a good place to started contributing to this repository.priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.
Milestone
Description
#134 adds type hints to the manual surface. That said, much of the merged types, maybe all, do not type params to functions. For instance:
async def list_documents(
self, page_size=None
) -> AsyncGenerator[AsyncDocumentReference, None]
page_size is an int. Adding these type hints would further assist users.
Work should target v2-staging branch for the time being.
Metadata
Metadata
Assignees
Labels
api: firestoreIssues related to the googleapis/python-firestore API.Issues related to the googleapis/python-firestore API.good first issueThis issue is a good place to started contributing to this repository.This issue is a good place to started contributing to this repository.priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.