Skip to content

Improve type hints, add types to method params #140

@crwilcox

Description

@crwilcox

#134 adds type hints to the manual surface. That said, much of the merged types, maybe all, do not type params to functions. For instance:

    async def list_documents(
        self, page_size=None
    ) -> AsyncGenerator[AsyncDocumentReference, None]

page_size is an int. Adding these type hints would further assist users.

Work should target v2-staging branch for the time being.

Metadata

Metadata

Labels

api: firestoreIssues related to the googleapis/python-firestore API.good first issueThis issue is a good place to started contributing to this repository.priority: p2Moderately-important priority. Fix may not be included in next release.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions