Skip to content

test: add claude models tests in us-east5 #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shobsi merged 2 commits into from
Aug 21, 2024
Merged

test: add claude models tests in us-east5 #908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7dff3ed
test: add claude models tests in us-east5
GarrettWu Aug 20, 2024
5299547
docs fix
GarrettWu Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/templates/toc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,8 @@
uid: bigframes.ml.llm.PaLM2TextGenerator
- name: PaLM2TextEmbeddingGenerator
uid: bigframes.ml.llm.PaLM2TextEmbeddingGenerator
- name: TextEmbeddingGenerator
Copy link
Contributor

@shobsi shobsi Aug 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

uid: bigframes.ml.llm.TextEmbeddingGenerator
- name: Claude3TextGenerator
uid: bigframes.ml.llm.Claude3TextGenerator
name: llm
Expand Down
19 changes: 12 additions & 7 deletions tests/system/small/ml/test_llm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,14 +405,15 @@ def test_gemini_text_generator_predict_with_params_success(
assert all(series.str.len() > 20)


# TODO(garrettwu): add tests for claude3.5 sonnet and claude3 opus as they are only available in other regions.
@pytest.mark.parametrize(
"model_name",
("claude-3-sonnet", "claude-3-haiku"),
("claude-3-sonnet", "claude-3-haiku", "claude-3-5-sonnet", "claude-3-opus"),
)
def test_claude3_text_generator_create_load(
dataset_id, model_name, session, bq_connection
dataset_id, model_name, session, session_us_east5, bq_connection
):
if model_name in ("claude-3-5-sonnet", "claude-3-opus"):
session = session_us_east5
claude3_text_generator_model = llm.Claude3TextGenerator(
model_name=model_name, connection_name=bq_connection, session=session
)
Expand All @@ -430,12 +431,14 @@ def test_claude3_text_generator_create_load(

@pytest.mark.parametrize(
"model_name",
("claude-3-sonnet", "claude-3-haiku"),
("claude-3-sonnet", "claude-3-haiku", "claude-3-5-sonnet", "claude-3-opus"),
)
@pytest.mark.flaky(retries=2)
def test_claude3_text_generator_predict_default_params_success(
llm_text_df, model_name, session, bq_connection
llm_text_df, model_name, session, session_us_east5, bq_connection
):
if model_name in ("claude-3-5-sonnet", "claude-3-opus"):
session = session_us_east5
claude3_text_generator_model = llm.Claude3TextGenerator(
model_name=model_name, connection_name=bq_connection, session=session
)
Expand All @@ -448,12 +451,14 @@ def test_claude3_text_generator_predict_default_params_success(

@pytest.mark.parametrize(
"model_name",
("claude-3-sonnet", "claude-3-haiku"),
("claude-3-sonnet", "claude-3-haiku", "claude-3-5-sonnet", "claude-3-opus"),
)
@pytest.mark.flaky(retries=2)
def test_claude3_text_generator_predict_with_params_success(
llm_text_df, model_name, session, bq_connection
llm_text_df, model_name, session, session_us_east5, bq_connection
):
if model_name in ("claude-3-5-sonnet", "claude-3-opus"):
session = session_us_east5
claude3_text_generator_model = llm.Claude3TextGenerator(
model_name=model_name, connection_name=bq_connection, session=session
)
Expand Down