Skip to content

Conversation

@GarrettWu
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@GarrettWu GarrettWu requested review from jiaxunwu and shobsi August 20, 2024 20:53
@GarrettWu GarrettWu requested review from a team as code owners August 20, 2024 20:53
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Aug 20, 2024
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Aug 20, 2024
@GarrettWu GarrettWu enabled auto-merge (squash) August 20, 2024 21:31
@GarrettWu GarrettWu disabled auto-merge August 20, 2024 22:47
@GarrettWu GarrettWu assigned GarrettWu and unassigned shobsi Aug 21, 2024
uid: bigframes.ml.llm.PaLM2TextGenerator
- name: PaLM2TextEmbeddingGenerator
uid: bigframes.ml.llm.PaLM2TextEmbeddingGenerator
- name: TextEmbeddingGenerator
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@shobsi shobsi merged commit 64044e6 into main Aug 21, 2024
@shobsi shobsi deleted the garrettwu-claude branch August 21, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants