Skip to content

fix: prevent creating unnecessary client objects in multithreaded environments #1757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2025
Merged

fix: prevent creating unnecessary client objects in multithreaded environments #1757

merged 1 commit into from
May 21, 2025

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented May 21, 2025

This prevents extra authentication and default location queries in multithreaded environments.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards internal issue b/419106112 🦕

@tswast
fix: prevent creating unnecessary client objects in multithreaded env…
821742c 
…ironments

This prevents extra authentication and default location queries in
multithreaded environments.
@tswast tswast requested review from a team as code owners May 21, 2025 17:59
@tswast tswast requested a review from chelsea-lin May 21, 2025 17:59
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels May 21, 2025
@tswast tswast mentioned this pull request May 21, 2025
Merged
3 tasks
@tswast tswast merged commit 1cf9f5e into main May 21, 2025
24 checks passed
@tswast tswast deleted the b419106112-default-location-lock branch May 21, 2025 19:24
@release-please release-please bot mentioned this pull request May 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chelsea-lin chelsea-lin chelsea-lin approved these changes

Assignees

@Genesis929 Genesis929

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tswast @chelsea-lin @Genesis929