Skip to content

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented May 21, 2025

This allows for overriding requests-based settings such as the maximum connection pool size.

Todos:

Fixes internal issue b/419106112 🦕

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels May 21, 2025
@tswast tswast added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 21, 2025
@tswast
Copy link
Collaborator Author

tswast commented May 21, 2025

Wait for #1757 first. Done!

tswast added 2 commits May 21, 2025 13:07
This allows for overriding requests-based settings such as the maximum
connection pool size.
@tswast tswast force-pushed the b419106112-requests-transport-adapters branch from 426b763 to 409d91b Compare May 21, 2025 21:13
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels May 21, 2025
@tswast tswast marked this pull request as ready for review May 21, 2025 21:13
@tswast tswast requested review from a team as code owners May 21, 2025 21:13
@tswast tswast requested a review from sycai May 21, 2025 21:13
@tswast tswast removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 21, 2025
@tswast
Copy link
Collaborator Author

tswast commented May 22, 2025

test_credentials_need_reauthentication is a real failure. We no longer pass in a credentials object.

sycai
sycai previously approved these changes May 29, 2025
@tswast tswast enabled auto-merge (squash) May 29, 2025 21:00
@tswast
Copy link
Collaborator Author

tswast commented May 30, 2025

test_credentials_need_reauthentication failure is a real one. No _credentials anymore. Investigating how best to address now.

@tswast tswast merged commit bb45db8 into main May 30, 2025
18 of 24 checks passed
@tswast tswast deleted the b419106112-requests-transport-adapters branch May 30, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants