-
Notifications
You must be signed in to change notification settings - Fork 22
docs: improve PredictTextSentimentAnalysisSample
#1098
docs: improve PredictTextSentimentAnalysisSample
#1098
Conversation
|
I thought about adding a test case for an input with |
|
Tagging @Sita04 for initial review. |
Sita04
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. LGTM.
@kurtisvg Back to you again for the final review.
|
@kurtisvg is this waiting on anything to move forward? *following up here as it's been on my |
|
Looks like it's approved by the language reviewer (me + @Sita04) and just needs to be approved by a product reviewer (@googleapis/cdpe-cloudai) |
balajismaniam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
Thank you for your contribution, and apologies for the delay in getting this merged @wallind. We have actually migrated all of our Java samples to a centralized repo https://github.com/GoogleCloudPlatform/java-docs-samples, and will be deleting the samples here. We can review and merge if you'd like to submit the PR there. Thanks again! |
@kweinmeister no problem. and done GoogleCloudPlatform/java-docs-samples#7562! can't wait to get this change added 😁 |
|
superseded by PR in the new repo GoogleCloudPlatform/java-docs-samples#7562 |
Description
Updates a code sample to have safe serialization of input which may come unsanitized.
Github Ticket(s)
Fixes #1097 ☕️
Checklist