Skip to content
This repository was archived by the owner on Sep 9, 2023. It is now read-only.

Conversation

@wallind
Copy link

@wallind wallind commented Oct 10, 2022

Description

Updates a code sample to have safe serialization of input which may come unsanitized.

Github Ticket(s)

Fixes #1097 ☕️

Checklist

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: vertex-ai Issues related to the googleapis/java-aiplatform API. labels Oct 10, 2022
@wallind
Copy link
Author

wallind commented Oct 10, 2022

I thought about adding a test case for an input with ". Would that be worth it? I opted not to for my inital draft. lemme know.

@wallind wallind marked this pull request as ready for review October 10, 2022 23:15
@wallind wallind requested review from a team as code owners October 10, 2022 23:15
@alicejli alicejli added the samples Issues that are directly related to samples. label Oct 12, 2022
@kurtisvg kurtisvg requested a review from Sita04 October 12, 2022 18:02
@kurtisvg
Copy link

Tagging @Sita04 for initial review.

Copy link

@Sita04 Sita04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. LGTM.

@kurtisvg Back to you again for the final review.

@wallind
Copy link
Author

wallind commented Nov 30, 2022

@kurtisvg is this waiting on anything to move forward? *following up here as it's been on my TODO: list to get this closed

@kurtisvg
Copy link

Looks like it's approved by the language reviewer (me + @Sita04) and just needs to be approved by a product reviewer (@googleapis/cdpe-cloudai)

Copy link

@balajismaniam balajismaniam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kweinmeister
Copy link
Contributor

Thank you for your contribution, and apologies for the delay in getting this merged @wallind.

We have actually migrated all of our Java samples to a centralized repo https://github.com/GoogleCloudPlatform/java-docs-samples, and will be deleting the samples here.

We can review and merge if you'd like to submit the PR there. Thanks again!

@wallind
Copy link
Author

wallind commented Jan 13, 2023

Thank you for your contribution, and apologies for the delay in getting this merged @wallind.

We have actually migrated all of our Java samples to a centralized repo https://github.com/GoogleCloudPlatform/java-docs-samples, and will be deleting the samples here.

We can review and merge if you'd like to submit the PR there. Thanks again!

@kweinmeister no problem. and done GoogleCloudPlatform/java-docs-samples#7562! can't wait to get this change added 😁

@wallind
Copy link
Author

wallind commented Feb 14, 2023

superseded by PR in the new repo GoogleCloudPlatform/java-docs-samples#7562

@wallind wallind closed this Feb 14, 2023
@wallind wallind deleted the 1097-improve-PredictTextSentimentAnalysisSample branch February 14, 2023 20:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: vertex-ai Issues related to the googleapis/java-aiplatform API. samples Issues that are directly related to samples. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: PredictTextSentimentAnalysisSample uses unsafe JSON serialization strategy

6 participants