Skip to content

Conversation

@wallind
Copy link
Contributor

@wallind wallind commented Jan 13, 2023

Description

Updates a code sample to have safe serialization of input which may come unsanitized.

Additional Context

I was referred here by @kweinmeister as I'm told this is the new house of what used to live at https://github.com/googleapis/java-aiplatform.

This PR is duplicate of one there: googleapis/java-aiplatform#1098

Github Ticket(s)

Fixes #7561 ☕️

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • API's need to be enabled to test (tell us)
  • Environment Variables need to be set (ask us to set them)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • Please merge this PR for me once it is approved.

@wallind wallind requested review from a team and yoshi-approver as code owners January 13, 2023 00:25
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jan 13, 2023
@wallind
Copy link
Contributor Author

wallind commented Jan 13, 2023

API's need to be enabled to test (tell us)
Environment Variables need to be set (ask us to set them)

apparently per the checklist I need to ask for you guys to do these things? I didn't mess with anything remotely complex so I can't see how it applies to me but asking none-the-less.

@kweinmeister kweinmeister added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 13, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 13, 2023
@wallind wallind force-pushed the 1097-improve-PredictTextSentimentAnalysisSample branch from b3527b1 to 026adba Compare February 5, 2023 16:43
@wallind wallind requested review from averikitsch and kweinmeister and removed request for averikitsch February 5, 2023 16:46
@anguillanneuf anguillanneuf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 6, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 6, 2023
@anguillanneuf anguillanneuf self-requested a review February 6, 2023 18:29
@wallind wallind force-pushed the 1097-improve-PredictTextSentimentAnalysisSample branch from 026adba to 52d3f09 Compare February 7, 2023 00:51
@kweinmeister kweinmeister added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 8, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 8, 2023
@averikitsch averikitsch added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Feb 14, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 14, 2023
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 14, 2023
@averikitsch averikitsch added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 14, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 14, 2023
@averikitsch averikitsch merged commit b1e4eef into GoogleCloudPlatform:main Feb 14, 2023
@wallind wallind deleted the 1097-improve-PredictTextSentimentAnalysisSample branch February 14, 2023 20:45
@wallind
Copy link
Contributor Author

wallind commented Feb 14, 2023

thanks for the collaboration guys! low key can't wait for my changes to be rendering on a GCP hosted docs page 👨‍💻 . That sweet sweet GCP street cred.

@kweinmeister
Copy link
Contributor

Thanks for your contribution, @wallind!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: PredictTextSentimentAnalysisSample uses unsafe JSON serialization strategy

5 participants