-
Notifications
You must be signed in to change notification settings - Fork 2.9k
docs: improve PredictTextSentimentAnalysisSample
#7562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: improve PredictTextSentimentAnalysisSample
#7562
Conversation
apparently per the checklist I need to ask for you guys to do these things? I didn't mess with anything remotely complex so I can't see how it applies to me but asking none-the-less. |
aiplatform/src/main/java/aiplatform/PredictTextSentimentAnalysisSample.java
Show resolved
Hide resolved
b3527b1 to
026adba
Compare
aiplatform/src/main/java/aiplatform/PredictTextSentimentAnalysisSample.java
Outdated
Show resolved
Hide resolved
026adba to
52d3f09
Compare
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
|
thanks for the collaboration guys! low key can't wait for my changes to be rendering on a GCP hosted docs page 👨💻 . That sweet sweet GCP street cred. |
|
Thanks for your contribution, @wallind! |
Description
Updates a code sample to have safe serialization of input which may come unsanitized.
Additional Context
I was referred here by @kweinmeister as I'm told this is the new house of what used to live at https://github.com/googleapis/java-aiplatform.
This PR is duplicate of one there: googleapis/java-aiplatform#1098
Github Ticket(s)
Fixes #7561 ☕️
Checklist
pom.xmlparent set to latestshared-configurationmvn clean verifyrequiredmvn -P lint checkstyle:checkrequiredmvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory only